From: Andrea Arcangeli <andrea@suse.de>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Andrew Morton <akpm@digeo.com>, David Miller <davem@redhat.com>,
rmk@arm.linux.org.uk, ak@muc.de, davidm@napali.hpl.hp.com,
anton@samba.org, linux-mm@kvack.org, rth@twiddle.net
Subject: Re: Linus rollup
Date: Thu, 30 Jan 2003 18:50:06 +0100 [thread overview]
Message-ID: <20030130175006.GO18538@dualathlon.random> (raw)
In-Reply-To: <1043948226.10150.587.camel@dell_ss3.pdx.osdl.net>
On Thu, Jan 30, 2003 at 09:37:06AM -0800, Stephen Hemminger wrote:
>
> > you certainly mean wmb() not rmb(), right? If yes, then yes.
> >
> > I actually didn't notice the write_begin/end, not sure who could need
> > them, I would suggest removing them, rather than to revert the mb()
> > there too.
>
> The write_begin/end was suggested by Andrew as a simplification for use
> when using this to update values already write-locked by other means.
>
> One possible usage was to fix the race issues with non-atomic update
> of 64 bit i_size.
It looks overdesign to me, you don't need the spinlock for that, the
i_sem is explicit too. The generalized abstraction is worthwhile when
you have to use it 99% of the time, the missing 1% doesn't need to be
abstracted, forward porting my implementation is the best for such
specific case IMHO.
Andrea
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2003-01-30 17:50 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-29 6:07 Linus rollup Andrew Morton
2003-01-29 6:53 ` David Mosberger
2003-01-29 7:25 ` David S. Miller
2003-01-29 9:33 ` Andrew Morton
2003-01-29 9:35 ` David S. Miller
2003-01-29 9:54 ` Anton Blanchard
2003-01-29 9:59 ` Russell King
2003-01-29 9:51 ` David S. Miller
2003-01-29 10:26 ` Andrew Morton
2003-01-29 22:35 ` Stephen Hemminger
2003-01-29 23:12 ` Andrew Morton
2003-01-30 0:30 ` David S. Miller
2003-01-30 1:27 ` Andrew Morton
2003-01-30 1:24 ` Andi Kleen
2003-01-30 2:01 ` Andrew Morton
2003-01-30 1:35 ` Andrea Arcangeli
2003-01-30 2:00 ` Andrew Morton
2003-01-30 1:50 ` Jeff Garzik
2003-01-30 2:03 ` Andrea Arcangeli
2003-01-30 17:09 ` Stephen Hemminger
2003-01-30 17:15 ` Randy.Dunlap
2003-01-30 17:25 ` Andi Kleen
2003-01-30 17:23 ` Randy.Dunlap
2003-01-30 1:52 ` Richard Henderson
2003-01-30 2:06 ` Andrea Arcangeli
2003-01-30 1:54 ` Andrea Arcangeli
2003-01-30 2:19 ` Andrew Morton
2003-01-30 17:37 ` Stephen Hemminger
2003-01-30 17:50 ` Andrea Arcangeli [this message]
2003-01-30 2:00 ` Richard Henderson
2003-01-30 0:46 ` Andrea Arcangeli
2003-01-30 0:43 ` Andrea Arcangeli
2003-01-29 10:16 ` Andrew Morton
2003-01-29 17:04 ` David Mosberger
2003-01-29 17:25 ` Russell King
2003-01-29 19:05 ` David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030130175006.GO18538@dualathlon.random \
--to=andrea@suse.de \
--cc=ak@muc.de \
--cc=akpm@digeo.com \
--cc=anton@samba.org \
--cc=davem@redhat.com \
--cc=davidm@napali.hpl.hp.com \
--cc=linux-mm@kvack.org \
--cc=rmk@arm.linux.org.uk \
--cc=rth@twiddle.net \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.