From: Dave Jones <davej@codemonkey.org.uk>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, pcihpd-discuss@lists.sourceforge.net
Subject: Re: [BK PATCH] PCI and PCI Hotplug changes and fixes for 2.5.70
Date: Thu, 5 Jun 2003 09:38:15 +0100 [thread overview]
Message-ID: <20030605083815.GA16879@suse.de> (raw)
In-Reply-To: <20030605021452.GA15711@kroah.com>
On Wed, Jun 04, 2003 at 07:14:52PM -0700, Greg KH wrote:
> > p.s. I'll send these as patches in response to this email to lkml for
> > those who want to see them.
>
> I don't think everyone really wants to see all 63 different
> pci_for_each_dev() removal patches
I'm puzzled why you did..
- pci_for_each_dev(device)
+ while ((device = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, device)) != NULL)
when you could have just added whatever locking pci_find_device() does
to pci_for_each_dev() You'd then not have had to touch any of these
drivers, and it'd look a damn sight better to look at IMO.
Dave
next prev parent reply other threads:[~2003-06-05 8:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-05 1:31 [BK PATCH] PCI and PCI Hotplug changes and fixes for 2.5.70 Greg KH
2003-06-05 2:05 ` [PATCH] " Greg KH
2003-06-05 2:05 ` Greg KH
2003-06-05 2:05 ` Greg KH
2003-06-05 2:05 ` Greg KH
2003-06-05 2:05 ` Greg KH
2003-06-05 2:05 ` Greg KH
2003-06-05 2:05 ` Greg KH
2003-06-05 2:05 ` Greg KH
2003-06-05 2:05 ` Greg KH
2003-06-05 2:05 ` Greg KH
2003-06-05 2:05 ` Greg KH
2003-06-05 9:19 ` Russell King
2003-06-05 17:04 ` Greg KH
2003-06-05 17:57 ` Russell King
2003-06-05 2:14 ` [BK PATCH] " Greg KH
2003-06-05 8:38 ` Dave Jones [this message]
2003-06-05 8:49 ` Greg KH
2003-06-05 8:59 ` Dave Jones
2003-06-05 9:06 ` Greg KH
2003-06-05 9:18 ` Dave Jones
2003-06-05 9:22 ` Russell King
2003-06-05 17:18 ` Greg KH
2003-06-05 19:10 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030605083815.GA16879@suse.de \
--to=davej@codemonkey.org.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pcihpd-discuss@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.