All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Dave Jones <davej@codemonkey.org.uk>,
	linux-kernel@vger.kernel.org,
	pcihpd-discuss@lists.sourceforge.net
Subject: Re: [BK PATCH] PCI and PCI Hotplug changes and fixes for 2.5.70
Date: Thu, 5 Jun 2003 10:18:35 -0700	[thread overview]
Message-ID: <20030605171835.GC5424@kroah.com> (raw)
In-Reply-To: <20030605091802.GA17356@suse.de>

On Thu, Jun 05, 2003 at 10:18:02AM +0100, Dave Jones wrote:
> 
> The fact that a tree-wide 'cleanup' like this goes in just a few hours
> after its posted before chance to comment is another argument, but
> concentrating on the technical point here, I still think this is a
> step backwards.

Why?  I just got rid of a function (well macro) that isn't even needed
(as proven by replacing it with an existing function.)  That's
technically a good thing :)

Now I can agree that some of those replacements could be done with a
different function call, as almost none of the replacements in the
driver/* tree really want to walk all of the pci devices in the tree.
They usually just want to walk all devices of a type of pci device (be
it capability, or other trait.)  I'd be glad to take changes of this
sort in the future.

thanks,

greg k-h

  parent reply	other threads:[~2003-06-05 17:03 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-05  1:31 [BK PATCH] PCI and PCI Hotplug changes and fixes for 2.5.70 Greg KH
2003-06-05  2:05 ` [PATCH] " Greg KH
2003-06-05  2:05   ` Greg KH
2003-06-05  2:05     ` Greg KH
2003-06-05  2:05       ` Greg KH
2003-06-05  2:05         ` Greg KH
2003-06-05  2:05           ` Greg KH
2003-06-05  2:05             ` Greg KH
2003-06-05  2:05               ` Greg KH
2003-06-05  2:05                 ` Greg KH
2003-06-05  2:05                   ` Greg KH
2003-06-05  2:05                     ` Greg KH
2003-06-05  9:19                 ` Russell King
2003-06-05 17:04                   ` Greg KH
2003-06-05 17:57                     ` Russell King
2003-06-05  2:14 ` [BK PATCH] " Greg KH
2003-06-05  8:38   ` Dave Jones
2003-06-05  8:49     ` Greg KH
2003-06-05  8:59       ` Dave Jones
2003-06-05  9:06         ` Greg KH
2003-06-05  9:18           ` Dave Jones
2003-06-05  9:22             ` Russell King
2003-06-05 17:18             ` Greg KH [this message]
2003-06-05 19:10               ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030605171835.GC5424@kroah.com \
    --to=greg@kroah.com \
    --cc=davej@codemonkey.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pcihpd-discuss@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.