From: Dave Jones <davej@codemonkey.org.uk>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, pcihpd-discuss@lists.sourceforge.net
Subject: Re: [BK PATCH] PCI and PCI Hotplug changes and fixes for 2.5.70
Date: Thu, 5 Jun 2003 10:18:02 +0100 [thread overview]
Message-ID: <20030605091802.GA17356@suse.de> (raw)
In-Reply-To: <20030605090645.GA2887@kroah.com>
On Thu, Jun 05, 2003 at 02:06:45AM -0700, Greg KH wrote:
> > so why not..
> >
> > #define pci_for_each_dev(dev) \
> > while ((device = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, device)) != NULL)
> >
> > ?
> >
> > Seems to be the same change you made tree-wide, with minimal
> > interruption to drivers.
>
> But that would have changed the way that pci_for_each_dev() works.
> It would require that dev=NULL before the function is called.
trivial to fix.
> And having
> the same function work subtly different on different kernel versions
> would not be the best thing.
ditto.
> Getting rid of it entirely was the better
> option, and now that Linus has pulled it, we don't have to worry about
> it anymore :)
The fact that a tree-wide 'cleanup' like this goes in just a few hours
after its posted before chance to comment is another argument, but
concentrating on the technical point here, I still think this is a
step backwards.
Dave
next prev parent reply other threads:[~2003-06-05 9:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-05 1:31 [BK PATCH] PCI and PCI Hotplug changes and fixes for 2.5.70 Greg KH
2003-06-05 2:05 ` [PATCH] " Greg KH
2003-06-05 2:05 ` Greg KH
2003-06-05 2:05 ` Greg KH
2003-06-05 2:05 ` Greg KH
2003-06-05 2:05 ` Greg KH
2003-06-05 2:05 ` Greg KH
2003-06-05 2:05 ` Greg KH
2003-06-05 2:05 ` Greg KH
2003-06-05 2:05 ` Greg KH
2003-06-05 2:05 ` Greg KH
2003-06-05 2:05 ` Greg KH
2003-06-05 9:19 ` Russell King
2003-06-05 17:04 ` Greg KH
2003-06-05 17:57 ` Russell King
2003-06-05 2:14 ` [BK PATCH] " Greg KH
2003-06-05 8:38 ` Dave Jones
2003-06-05 8:49 ` Greg KH
2003-06-05 8:59 ` Dave Jones
2003-06-05 9:06 ` Greg KH
2003-06-05 9:18 ` Dave Jones [this message]
2003-06-05 9:22 ` Russell King
2003-06-05 17:18 ` Greg KH
2003-06-05 19:10 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030605091802.GA17356@suse.de \
--to=davej@codemonkey.org.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pcihpd-discuss@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.