All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: LM83 driver
Date: Thu, 19 May 2005 06:24:03 +0000	[thread overview]
Message-ID: <20030705195746.6565ea15.khali@linux-fr.org> (raw)
In-Reply-To: <20030703194558.60bc8955.khali@linux-fr.org>


If anyone could take a look at my code for the LM83, I'd appreciate it.
This is my first driver, as you must know. I followed the guidelines in
doc/developers/new_drivers, tried to follow the coding standards, but I
may have missed a few things.

I propose the following changes to new_drivers file:

- Change the recommended driver to use as a template. The writer should
use the driver that is the more similar to the chip he is writing a
driver for. I personally used much more the lm75 and adm1021 drivers
than the recommended lm78. And actually, using two different drivers as
templates was great.

- Don't ask for testing with 2.2 kernels! Maybe we should add a line
about sending a 2.5 version (if possible) to Greg KH instead?

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/

  parent reply	other threads:[~2005-05-19  6:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-19  6:24 LM83 driver Jean Delvare
2005-05-19  6:24 ` Jean Delvare
2005-05-19  6:24 ` Jean Delvare [this message]
2005-05-19  6:24 ` Greg KH
2005-05-19  6:24 ` Greg KH
2005-05-19  6:24 ` Jean Delvare
2005-05-19  6:24 ` Mark D. Studebaker 
2005-05-19  6:24 ` Jean Delvare
2005-05-19  6:24 ` Greg KH
2005-05-19  6:24 ` Jean Delvare
2005-05-19  6:24 ` Philip Pokorny
2005-05-19  6:24 ` Mark D. Studebaker 
2005-05-19  6:24 ` Jean Delvare
2005-05-19  6:24 ` Jean Delvare
2005-05-19  6:24 ` Mark D. Studebaker 
2005-05-19  6:24 ` Jean Delvare
2005-05-19  6:24 ` ZOleg Matrix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030705195746.6565ea15.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.