From: mds@paradyne.com (Mark D. Studebaker )
To: lm-sensors@vger.kernel.org
Subject: LM83 driver
Date: Thu, 19 May 2005 06:24:06 +0000 [thread overview]
Message-ID: <3F19E82E.2080409@paradyne.com> (raw)
In-Reply-To: <20030703194558.60bc8955.khali@linux-fr.org>
Jean Delvare wrote:
>>- You could have done one /proc callback function rather than 4
>
>
> Hm, how do I know who's calling me then? Using ctl_name and the
> LM83_SYSCTL_* constants defined earlier? I don't exactly see the
> interest yet. Though the functions are similar, most of the code really
> depend on the sensor, so I don't think we'll win in clarity nor code
> size. But maybe it's just me. Where could I look at a similar situation
> in our code?
>
See w83781d_pwm() in w83781d.c which uses subtraction to convert the SYSCTL number
to PWM number, and the W83781D_REG_PWM macro which indexes into a static array of
register numbers.
next prev parent reply other threads:[~2005-05-19 6:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-19 6:24 LM83 driver Jean Delvare
2005-05-19 6:24 ` Greg KH
2005-05-19 6:24 ` Jean Delvare
2005-05-19 6:24 ` Greg KH
2005-05-19 6:24 ` Jean Delvare
2005-05-19 6:24 ` Jean Delvare
2005-05-19 6:24 ` Greg KH
2005-05-19 6:24 ` Philip Pokorny
2005-05-19 6:24 ` Jean Delvare
2005-05-19 6:24 ` Mark D. Studebaker
2005-05-19 6:24 ` Jean Delvare
2005-05-19 6:24 ` Jean Delvare
2005-05-19 6:24 ` Jean Delvare
2005-05-19 6:24 ` Jean Delvare
2005-05-19 6:24 ` Mark D. Studebaker [this message]
2005-05-19 6:24 ` Mark D. Studebaker
2005-05-19 6:24 ` ZOleg Matrix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F19E82E.2080409@paradyne.com \
--to=mds@paradyne.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.