All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: LM83 driver
Date: Thu, 19 May 2005 06:24:06 +0000	[thread overview]
Message-ID: <20030721121217.1c28ef16.khali@linux-fr.org> (raw)
In-Reply-To: <20030703194558.60bc8955.khali@linux-fr.org>


> Of course with libsensors apps you don't care about /proc standards.
> 
> The benefit is in writing simple non-libsensors scripts, etc.
> (see our new prog/pwm/pwmconfig) which are only feasible if we follow
> consistent standards for /proc.

I read that script and fancontrol too, and I admit fancontrol wouldn't
work if there were 2-values temp files. It's really easy to fix though.
Just replace "cut -d' ' -f3" with "sed -e 's/^.* \(.*\)$/\1/'" and it's
done (I think awk would be better to do that, but unfortunately I don't
know awk at all).

Having 2-temp files (or 1-temp, or 4-temp) causes IMHO far less problems
than other differences we already have. This can always be workarounded
in scripts, as long as the first temp is the high limit, and the last
one is the current value (and my driver respects that). The fact that
some drivers output values that are *not* the real temps and that a
conversion formula is required is much more trouble, and that's the way
our drivers work however (or what would be sensors.conf for?) so the
non-libsensors scripts already have to handle that.

Maybe there will be some script to fix if we decide to allow
non-3-values temperature files, but I really think it will always be
easy and it makes the drivers easier to write, maintain and in some
cases even use.

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/

  parent reply	other threads:[~2005-05-19  6:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-19  6:24 LM83 driver Jean Delvare
2005-05-19  6:24 ` Jean Delvare
2005-05-19  6:24 ` Greg KH
2005-05-19  6:24 ` Jean Delvare
2005-05-19  6:24 ` Jean Delvare
2005-05-19  6:24 ` Greg KH
2005-05-19  6:24 ` Greg KH
2005-05-19  6:24 ` Jean Delvare
2005-05-19  6:24 ` Philip Pokorny
2005-05-19  6:24 ` Jean Delvare
2005-05-19  6:24 ` Mark D. Studebaker 
2005-05-19  6:24 ` Mark D. Studebaker 
2005-05-19  6:24 ` Jean Delvare
2005-05-19  6:24 ` Jean Delvare [this message]
2005-05-19  6:24 ` Jean Delvare
2005-05-19  6:24 ` Mark D. Studebaker 
2005-05-19  6:24 ` ZOleg Matrix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030721121217.1c28ef16.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.