i2c-2.8.0 USBVision Patch

i2c-2.8.0 USBVision Patch

[Jean Delvare]

> I happen to stumble on your conversation and patch.  
> 
> Thanks,  I will update our code base.

Once done, please confirm which constant you have been using and if you
want a comment associated in i2c-id.h.

Thanks.

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/

i2c-2.8.0 USBVision Patch

[Dwaine Garden]

Jean Delvare wrote:

>>I happen to stumble on your conversation and patch.  
>>
>>Thanks,  I will update our code base.
>>    
>>
>
>Once done, please confirm which constant you have been using and if you
>want a comment associated in i2c-id.h.
>
>Thanks.
>
>  
>
Please change the following...

.id                = I2C_HW_B_BT848,

to the following...

.id                = I2C_USBVISION,

Thanks....
Dwaine.
http://www.emuit.com/webcam.html

i2c-2.8.0 USBVision Patch

[Jean Delvare]

> Please change the following...
> 
> .id                = I2C_HW_B_BT848,
> 
> to the following...
> 
> .id                = I2C_USBVISION,

That ID is for an adapter, so it has to be I2C_HW_USBVISION (or even
longer? Please take a look at i2c-id.h in the Linux kernel sources and
tell me what you think).

Also, there's a second ID you'd need to change: I2C_ALGO_BIT should
become I2C_ALGO_USB, right?

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/

i2c-2.8.0 USBVision Patch

[Dwaine Garden]

Jean Delvare wrote:

>>Please change the following...
>>
>>.id                = I2C_HW_B_BT848,
>>
>>to the following...
>>
>>.id                = I2C_USBVISION,
>>    
>>
>
>That ID is for an adapter, so it has to be I2C_HW_USBVISION (or even
>longer? Please take a look at i2c-id.h in the Linux kernel sources and
>tell me what you think).
>
>Also, there's a second ID you'd need to change: I2C_ALGO_BIT should
>become I2C_ALGO_USB, right?
>
>  
>
Sounds great to me....  I would like to keep it basically like 
everything else.  I checked out the i2c-id.h file.

a)  I2C_HW_B_USBVISION
b) I2C_ALGO_USB

Thanks...

Dwaine.

i2c-2.8.0 USBVision Patch

[Jean Delvare]

> Sounds great to me....  I would like to keep it basically like 
> everything else.  I checked out the i2c-id.h file.
> 
> a)  I2C_HW_B_USBVISION
> b) I2C_ALGO_USB

I'm not sure about I2C_HW_B_USBVISION. I'd tend to say that _B_ is for
adapters that use the i2c-algo-bit algorithm layer, which isn't your
case, unless I'm missing something. So I'm now wondering if it shouldn't
be I2C_HW_USB_USBVISION or something similar, since you are using your
own algorithm.

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/

i2c-2.8.0 USBVision Patch

[Dwaine Garden]

Jean Delvare wrote:

>>Sounds great to me....  I would like to keep it basically like 
>>everything else.  I checked out the i2c-id.h file.
>>
>>a)  I2C_HW_B_USBVISION
>>b) I2C_ALGO_USB
>>    
>>
>
>I'm not sure about I2C_HW_B_USBVISION. I'd tend to say that _B_ is for
>adapters that use the i2c-algo-bit algorithm layer, which isn't your
>case, unless I'm missing something. So I'm now wondering if it shouldn't
>be I2C_HW_USB_USBVISION or something similar, since you are using your
>own algorithm.
>
>  
>
Ok....

a) I2C_HW_USB_USBVISION
b) I2C_ALGO_USB

Dwaine.

i2c-2.8.0 USBVision Patch

[Jean Delvare]

> Ok....
> 
> a) I2C_HW_USB_USBVISION
> b) I2C_ALGO_USB

Done:

#define I2C_ALGO_USB	0x170000	/* USB algorithm		*/

/* --- USB based adapters						*/
#define I2C_HW_USB_USBVISION	0x00

(Not committed yet, will do ASAP.)

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/

i2c-2.8.0 USBVision Patch

[Jean Delvare]

> #define I2C_ALGO_USB	0x170000	/* USB algorithm		*/
> 
> /* --- USB based adapters						*/
> #define I2C_HW_USB_USBVISION	0x00
> 
> (Not committed yet, will do ASAP.)

Done.

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/