* i2c-2.8.0 USBVision Patch
2005-05-19 6:24 i2c-2.8.0 USBVision Patch Jean Delvare
@ 2005-05-19 6:24 ` Dwaine Garden
2005-05-19 6:24 ` Jean Delvare
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Dwaine Garden @ 2005-05-19 6:24 UTC (permalink / raw)
To: lm-sensors
Jean Delvare wrote:
>>Sounds great to me.... I would like to keep it basically like
>>everything else. I checked out the i2c-id.h file.
>>
>>a) I2C_HW_B_USBVISION
>>b) I2C_ALGO_USB
>>
>>
>
>I'm not sure about I2C_HW_B_USBVISION. I'd tend to say that _B_ is for
>adapters that use the i2c-algo-bit algorithm layer, which isn't your
>case, unless I'm missing something. So I'm now wondering if it shouldn't
>be I2C_HW_USB_USBVISION or something similar, since you are using your
>own algorithm.
>
>
>
Ok....
a) I2C_HW_USB_USBVISION
b) I2C_ALGO_USB
Dwaine.
^ permalink raw reply [flat|nested] 8+ messages in thread* i2c-2.8.0 USBVision Patch
2005-05-19 6:24 i2c-2.8.0 USBVision Patch Jean Delvare
2005-05-19 6:24 ` Dwaine Garden
@ 2005-05-19 6:24 ` Jean Delvare
2005-05-19 6:24 ` Dwaine Garden
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Jean Delvare @ 2005-05-19 6:24 UTC (permalink / raw)
To: lm-sensors
> #define I2C_ALGO_USB 0x170000 /* USB algorithm */
>
> /* --- USB based adapters */
> #define I2C_HW_USB_USBVISION 0x00
>
> (Not committed yet, will do ASAP.)
Done.
--
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
^ permalink raw reply [flat|nested] 8+ messages in thread* i2c-2.8.0 USBVision Patch
2005-05-19 6:24 i2c-2.8.0 USBVision Patch Jean Delvare
2005-05-19 6:24 ` Dwaine Garden
2005-05-19 6:24 ` Jean Delvare
@ 2005-05-19 6:24 ` Dwaine Garden
2005-05-19 6:24 ` Jean Delvare
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Dwaine Garden @ 2005-05-19 6:24 UTC (permalink / raw)
To: lm-sensors
Jean Delvare wrote:
>>I happen to stumble on your conversation and patch.
>>
>>Thanks, I will update our code base.
>>
>>
>
>Once done, please confirm which constant you have been using and if you
>want a comment associated in i2c-id.h.
>
>Thanks.
>
>
>
Please change the following...
.id = I2C_HW_B_BT848,
to the following...
.id = I2C_USBVISION,
Thanks....
Dwaine.
http://www.emuit.com/webcam.html
^ permalink raw reply [flat|nested] 8+ messages in thread* i2c-2.8.0 USBVision Patch
2005-05-19 6:24 i2c-2.8.0 USBVision Patch Jean Delvare
` (2 preceding siblings ...)
2005-05-19 6:24 ` Dwaine Garden
@ 2005-05-19 6:24 ` Jean Delvare
2005-05-19 6:24 ` Dwaine Garden
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Jean Delvare @ 2005-05-19 6:24 UTC (permalink / raw)
To: lm-sensors
> Sounds great to me.... I would like to keep it basically like
> everything else. I checked out the i2c-id.h file.
>
> a) I2C_HW_B_USBVISION
> b) I2C_ALGO_USB
I'm not sure about I2C_HW_B_USBVISION. I'd tend to say that _B_ is for
adapters that use the i2c-algo-bit algorithm layer, which isn't your
case, unless I'm missing something. So I'm now wondering if it shouldn't
be I2C_HW_USB_USBVISION or something similar, since you are using your
own algorithm.
--
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
^ permalink raw reply [flat|nested] 8+ messages in thread* i2c-2.8.0 USBVision Patch
2005-05-19 6:24 i2c-2.8.0 USBVision Patch Jean Delvare
` (3 preceding siblings ...)
2005-05-19 6:24 ` Jean Delvare
@ 2005-05-19 6:24 ` Dwaine Garden
2005-05-19 6:24 ` Jean Delvare
2005-05-19 6:24 ` Jean Delvare
6 siblings, 0 replies; 8+ messages in thread
From: Dwaine Garden @ 2005-05-19 6:24 UTC (permalink / raw)
To: lm-sensors
Jean Delvare wrote:
>>Please change the following...
>>
>>.id = I2C_HW_B_BT848,
>>
>>to the following...
>>
>>.id = I2C_USBVISION,
>>
>>
>
>That ID is for an adapter, so it has to be I2C_HW_USBVISION (or even
>longer? Please take a look at i2c-id.h in the Linux kernel sources and
>tell me what you think).
>
>Also, there's a second ID you'd need to change: I2C_ALGO_BIT should
>become I2C_ALGO_USB, right?
>
>
>
Sounds great to me.... I would like to keep it basically like
everything else. I checked out the i2c-id.h file.
a) I2C_HW_B_USBVISION
b) I2C_ALGO_USB
Thanks...
Dwaine.
^ permalink raw reply [flat|nested] 8+ messages in thread* i2c-2.8.0 USBVision Patch
2005-05-19 6:24 i2c-2.8.0 USBVision Patch Jean Delvare
` (4 preceding siblings ...)
2005-05-19 6:24 ` Dwaine Garden
@ 2005-05-19 6:24 ` Jean Delvare
2005-05-19 6:24 ` Jean Delvare
6 siblings, 0 replies; 8+ messages in thread
From: Jean Delvare @ 2005-05-19 6:24 UTC (permalink / raw)
To: lm-sensors
> Please change the following...
>
> .id = I2C_HW_B_BT848,
>
> to the following...
>
> .id = I2C_USBVISION,
That ID is for an adapter, so it has to be I2C_HW_USBVISION (or even
longer? Please take a look at i2c-id.h in the Linux kernel sources and
tell me what you think).
Also, there's a second ID you'd need to change: I2C_ALGO_BIT should
become I2C_ALGO_USB, right?
--
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
^ permalink raw reply [flat|nested] 8+ messages in thread* i2c-2.8.0 USBVision Patch
2005-05-19 6:24 i2c-2.8.0 USBVision Patch Jean Delvare
` (5 preceding siblings ...)
2005-05-19 6:24 ` Jean Delvare
@ 2005-05-19 6:24 ` Jean Delvare
6 siblings, 0 replies; 8+ messages in thread
From: Jean Delvare @ 2005-05-19 6:24 UTC (permalink / raw)
To: lm-sensors
> Ok....
>
> a) I2C_HW_USB_USBVISION
> b) I2C_ALGO_USB
Done:
#define I2C_ALGO_USB 0x170000 /* USB algorithm */
/* --- USB based adapters */
#define I2C_HW_USB_USBVISION 0x00
(Not committed yet, will do ASAP.)
--
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
^ permalink raw reply [flat|nested] 8+ messages in thread