Alsa-1.0.0rc2 Hammerfall Light - small bug report

Alsa-1.0.0rc2 Hammerfall Light - small bug report

[Mark Knecht]

Hi,
   The Hammerfall Light driver has a couple of small bugs in the way it
identifies port status in /proc/asound where it lists the spdif port as
an ADAT port. I'm not using spdif on this machine so I cannot check to
see if it shows lock status correctly. Someone may want to look at this.

Cheers,
Mark




-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: Alsa-1.0.0rc2 Hammerfall Light - small bug report

[Mark Knecht]

On Sat, 2003-12-06 at 17:28, Mark Knecht wrote:
> Hi,
>    The Hammerfall Light driver has a couple of small bugs in the way it
> identifies port status in /proc/asound where it lists the spdif port as
> an ADAT port. I'm not using spdif on this machine so I cannot check to
> see if it shows lock status correctly. Someone may want to look at this.
> 
> Cheers,
> Mark

Sorry. Forgot to attach what I saw. Note ADAT3 which do not exist on
this card.


[mark@localhost mark]$ cat /proc/asound/card0/rme9652 
RME Digi9636 (Rev 1.5) (Card #1)
Buffers: capture ee400000 playback ee000000
IRQ: 10 Registers bus: 0xf5000000 VM: 0xf091d000
Control register: 44006

Latency: 512 samples (2 periods of 2048 bytes)
Hardware pointer (frames): 0
Passthru: no
Clock mode: autosync
Pref. sync source: ADAT1

ADAT1 Input source: ADAT1 optical

IEC958 input: Coaxial
IEC958 output: Coaxial only
IEC958 quality: Consumer
IEC958 emphasis: off
IEC958 Dolby: off
IEC958 sample rate: error flag set

ADAT Sample rate: 44100Hz
ADAT1: No Lock
ADAT2: No Lock
ADAT3: No Lock

Timecode signal: no
Punch Status:

 1: off  2: off  3: off  4: off  5: off  6: off  7: off  8: off 
 9: off 10: off 11: off 12: off 13: off 14: off 15: off 16: off 
17: off 18: off 
[mark@localhost mark]$ 





-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: Alsa-1.0.0rc2 Hammerfall Light - small bug report

[Martin Langer]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

On Sat, Dec 06, 2003 at 06:15:19PM -0800, Mark Knecht wrote:
> 
> Note ADAT3 which do not exist on
> this card.
> 
> 
> [mark@localhost mark]$ cat /proc/asound/card0/rme9652 
[...]
> ADAT Sample rate: 44100Hz
> ADAT1: No Lock
> ADAT2: No Lock
> ADAT3: No Lock
> 

This patch will remove the ADAT3 entry for light users. Please try it out,
because I don't have any hammerfall hardware.


martin

[-- Attachment #2: rme9652.patch --]
[-- Type: text/plain, Size: 881 bytes --]

Index: alsa-kernel/pci/rme9652/rme9652.c
===================================================================
RCS file: /cvsroot/alsa/alsa-kernel/pci/rme9652/rme9652.c,v
retrieving revision 1.39
diff -u -r1.39 rme9652.c
--- alsa-kernel/pci/rme9652/rme9652.c	19 Dec 2003 09:27:04 -0000	1.39
+++ alsa-kernel/pci/rme9652/rme9652.c	2 Jan 2004 13:21:26 -0000
@@ -1798,11 +1798,13 @@
 		snd_iprintf(buffer, "ADAT2: No Lock\n");
 	}
 
-	x = status & RME9652_sync_2;
-	if (status & RME9652_lock_2) {
-		snd_iprintf(buffer, "ADAT3: %s\n", x ? "Sync" : "Lock");
-	} else {
-		snd_iprintf(buffer, "ADAT3: No Lock\n");
+	if (rme9652->ss_channels == RME9652_NCHANNELS) {
+		x = status & RME9652_sync_2;
+		if (status & RME9652_lock_2) {
+			snd_iprintf(buffer, "ADAT3: %s\n", x ? "Sync" : "Lock");
+		} else {
+			snd_iprintf(buffer, "ADAT3: No Lock\n");
+		}
 	}
 
 	snd_iprintf(buffer, "\n");

Re: Alsa-1.0.0rc2 Hammerfall Light - small bug report

[Mark Knecht]

On Fri, 2004-01-02 at 06:10, Martin Langer wrote:
> On Sat, Dec 06, 2003 at 06:15:19PM -0800, Mark Knecht wrote:
> > 
> > Note ADAT3 which do not exist on
> > this card.
> > 
> > 
> > [mark@localhost mark]$ cat /proc/asound/card0/rme9652 
> [...]
> > ADAT Sample rate: 44100Hz
> > ADAT1: No Lock
> > ADAT2: No Lock
> > ADAT3: No Lock
> > 
> 
> This patch will remove the ADAT3 entry for light users. Please try it out,
> because I don't have any hammerfall hardware.
> 
> 
> martin

Martin,
   Sorry, but I cannot try it out. My Hammerfall Light box is a
PlanetCCRMA machine which is RPM based. I wouldn't have a clue how to
patch an RPM to do this.

Sorry,
Mark



-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills.  Sign up for IBM's
Free Linux Tutorials.  Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click