[2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28

[2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28

[Jan De Luyck]

Hello list,

Today I discovered I could no longer create files on one of my boxes, which 
still runs 2.4.18 (box is too far away to upgrade right now). It gives me 
'disk full' messages.

The following message is all over my logs since January 3:

vs-2120: add_save_link: insert_item returned -28

I can't seem to find much on this issue, is this a bug in reiserfs (which is 
fixed in a later version)? Is something wrong with the fs itself?

Thanks for answers.

[I'm not subscribed @ reiserfs-list, so please cc me with answers from that 
list]

Jan
-- 
It is exactly because a man cannot do a thing that he is a proper judge of it.
		-- Oscar Wilde

Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28

[Jan De Luyck]

On Friday 09 January 2004 16:22, Jan De Luyck wrote:
> Hello list,
>
> Today I discovered I could no longer create files on one of my boxes, which
> still runs 2.4.18 (box is too far away to upgrade right now). It gives me
> 'disk full' messages.
>
> The following message is all over my logs since January 3:
>
> vs-2120: add_save_link: insert_item returned -28
>
> I can't seem to find much on this issue, is this a bug in reiserfs (which
> is fixed in a later version)? Is something wrong with the fs itself?
>
> Thanks for answers.

Nevermind this... I was looking at the wrong partition... for half an hour.... 

:-(

Jan
-- 
My apologies if I sound angry.  I feel like I'm talking to a void.
	-- Avery Pennarun

Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28

[Vladimir Saveliev]

Hello

On Fri, 2004-01-09 at 18:22, Jan De Luyck wrote:
> Hello list,
> 
> Today I discovered I could no longer create files on one of my boxes, which 
> still runs 2.4.18 (box is too far away to upgrade right now). It gives me 
> 'disk full' messages.
> 
> The following message is all over my logs since January 3:
> 
> vs-2120: add_save_link: insert_item returned -28
> 

This is just a warning. You should be able to free some disk space by
removing some files.



> I can't seem to find much on this issue, is this a bug in reiserfs (which is 
> fixed in a later version)? Is something wrong with the fs itself?
> 
> Thanks for answers.
> 
> [I'm not subscribed @ reiserfs-list, so please cc me with answers from that 
> list]
> 
> Jan

Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28

[Hans Reiser]

Vladimir Saveliev wrote:

>Hello
>
>On Fri, 2004-01-09 at 18:22, Jan De Luyck wrote:
>  
>
>>Hello list,
>>
>>Today I discovered I could no longer create files on one of my boxes, which 
>>still runs 2.4.18 (box is too far away to upgrade right now). It gives me 
>>'disk full' messages.
>>
>>The following message is all over my logs since January 3:
>>
>>vs-2120: add_save_link: insert_item returned -28
>>
>>    
>>
>
>This is just a warning. You should be able to free some disk space by
>removing some files.
>
>
>
>  
>
>>I can't seem to find much on this issue, is this a bug in reiserfs (which is 
>>fixed in a later version)? Is something wrong with the fs itself?
>>
>>Thanks for answers.
>>
>>[I'm not subscribed @ reiserfs-list, so please cc me with answers from that 
>>list]
>>
>>Jan
>>    
>>
>
>
>
>  
>
why do we generate this warning?  It should be fixed, yes?

-- 
Hans

Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28

[Vladimir Saveliev]

On Fri, 2004-01-16 at 11:48, Hans Reiser wrote:
> Vladimir Saveliev wrote:
> 
> >Hello
> >
> >On Fri, 2004-01-09 at 18:22, Jan De Luyck wrote:
> >  
> >
> >>Hello list,
> >>
> >>Today I discovered I could no longer create files on one of my boxes, which 
> >>still runs 2.4.18 (box is too far away to upgrade right now). It gives me 
> >>'disk full' messages.
> >>
> >>The following message is all over my logs since January 3:
> >>
> >>vs-2120: add_save_link: insert_item returned -28
> >>
> >>    
> >>
> >
> >This is just a warning. You should be able to free some disk space by
> >removing some files.
> >
> >
> >
> >  
> >
> >>I can't seem to find much on this issue, is this a bug in reiserfs (which is 
> >>fixed in a later version)? Is something wrong with the fs itself?
> >>
> >>Thanks for answers.
> >>
> >>[I'm not subscribed @ reiserfs-list, so please cc me with answers from that 
> >>list]
> >>
> >>Jan
> >>    
> >>
> >
> >
> >
> >  
> >
> why do we generate this warning?  It should be fixed, yes?

Yes

Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28

[Jan De Luyck]

On Friday 16 January 2004 10:11, Vladimir Saveliev wrote:
> On Fri, 2004-01-16 at 11:48, Hans Reiser wrote:
> > Vladimir Saveliev wrote:
> > >Hello
> > >
> > >On Fri, 2004-01-09 at 18:22, Jan De Luyck wrote:
> > >>Hello list,
> > >>
> > >>Today I discovered I could no longer create files on one of my boxes,
> > >> which still runs 2.4.18 (box is too far away to upgrade right now). It
> > >> gives me 'disk full' messages.
> > >>
> > >>The following message is all over my logs since January 3:
> > >>
> > >>vs-2120: add_save_link: insert_item returned -28
> > >
> > >This is just a warning. You should be able to free some disk space by
> > >removing some files.
> > >
> > >>I can't seem to find much on this issue, is this a bug in reiserfs
> > >> (which is fixed in a later version)? Is something wrong with the fs
> > >> itself?
> > >>
> > >>Thanks for answers.
> > >>
> > >>[I'm not subscribed @ reiserfs-list, so please cc me with answers from
> > >> that list]
> > >>
> > >>Jan
> >
> > why do we generate this warning?  It should be fixed, yes?
>
> Yes

Just returning a message that makes sense to people would be nice.

Jan

-- 
People think love is an emotion.  Love is good sense.
		-- Ken Kesey

Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28

[Hans Reiser]

Jan De Luyck wrote:

>On Friday 16 January 2004 10:11, Vladimir Saveliev wrote:
>  
>
>>On Fri, 2004-01-16 at 11:48, Hans Reiser wrote:
>>    
>>
>>>Vladimir Saveliev wrote:
>>>      
>>>
>>>>Hello
>>>>
>>>>On Fri, 2004-01-09 at 18:22, Jan De Luyck wrote:
>>>>        
>>>>
>>>>>Hello list,
>>>>>
>>>>>Today I discovered I could no longer create files on one of my boxes,
>>>>>which still runs 2.4.18 (box is too far away to upgrade right now). It
>>>>>gives me 'disk full' messages.
>>>>>
>>>>>The following message is all over my logs since January 3:
>>>>>
>>>>>vs-2120: add_save_link: insert_item returned -28
>>>>>          
>>>>>
>>>>This is just a warning. You should be able to free some disk space by
>>>>removing some files.
>>>>
>>>>        
>>>>
>>>>>I can't seem to find much on this issue, is this a bug in reiserfs
>>>>>(which is fixed in a later version)? Is something wrong with the fs
>>>>>itself?
>>>>>
>>>>>Thanks for answers.
>>>>>
>>>>>[I'm not subscribed @ reiserfs-list, so please cc me with answers from
>>>>>that list]
>>>>>
>>>>>Jan
>>>>>          
>>>>>
>>>why do we generate this warning?  It should be fixed, yes?
>>>      
>>>
>>Yes
>>    
>>
>
>Just returning a message that makes sense to people would be nice.
>
>Jan
>
>  
>
there is no need for a warning at all, it is a normal condition, and 
returning ENOSPACE says all that we should say.

-- 
Hans

Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28

[Vladimir Saveliev]

On Fri, 2004-01-16 at 15:40, Hans Reiser wrote:
> Jan De Luyck wrote:
> 
> >On Friday 16 January 2004 10:11, Vladimir Saveliev wrote:
> >  
> >
> >>On Fri, 2004-01-16 at 11:48, Hans Reiser wrote:
> >>    
> >>
> >>>Vladimir Saveliev wrote:
> >>>      
> >>>
> >>>>Hello
> >>>>
> >>>>On Fri, 2004-01-09 at 18:22, Jan De Luyck wrote:
> >>>>        
> >>>>
> >>>>>Hello list,
> >>>>>
> >>>>>Today I discovered I could no longer create files on one of my boxes,
> >>>>>which still runs 2.4.18 (box is too far away to upgrade right now). It
> >>>>>gives me 'disk full' messages.
> >>>>>
> >>>>>The following message is all over my logs since January 3:
> >>>>>
> >>>>>vs-2120: add_save_link: insert_item returned -28
> >>>>>          
> >>>>>
> >>>>This is just a warning. You should be able to free some disk space by
> >>>>removing some files.
> >>>>
> >>>>        
> >>>>
> >>>>>I can't seem to find much on this issue, is this a bug in reiserfs
> >>>>>(which is fixed in a later version)? Is something wrong with the fs
> >>>>>itself?
> >>>>>
> >>>>>Thanks for answers.
> >>>>>
> >>>>>[I'm not subscribed @ reiserfs-list, so please cc me with answers from
> >>>>>that list]
> >>>>>
> >>>>>Jan
> >>>>>          
> >>>>>
> >>>why do we generate this warning?  It should be fixed, yes?
> >>>      
> >>>
> >>Yes
> >>    
> >>
> >
> >Just returning a message that makes sense to people would be nice.
> >
> >Jan
> >
> >  
> >
> there is no need for a warning at all, it is a normal condition, and 
> returning ENOSPACE says all that we should say.

At this case we do not return ENOSPC. Operation which failed due to
ENOSPC was "save link" insertion. The major operation (unlink or
truncate) just continues without "save links". (save link are used to be
able to complete removal of unlinked/truncated files on reboot if they
did not manage to get properly removed/truncated due to unclean
shutdown).

Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28

[Hans Reiser]

Vladimir Saveliev wrote:

>On Fri, 2004-01-16 at 15:40, Hans Reiser wrote:
>  
>
>>Jan De Luyck wrote:
>>
>>    
>>
>>>On Friday 16 January 2004 10:11, Vladimir Saveliev wrote:
>>> 
>>>
>>>      
>>>
>>>>On Fri, 2004-01-16 at 11:48, Hans Reiser wrote:
>>>>   
>>>>
>>>>        
>>>>
>>>>>Vladimir Saveliev wrote:
>>>>>     
>>>>>
>>>>>          
>>>>>
>>>>>>Hello
>>>>>>
>>>>>>On Fri, 2004-01-09 at 18:22, Jan De Luyck wrote:
>>>>>>       
>>>>>>
>>>>>>            
>>>>>>
>>>>>>>Hello list,
>>>>>>>
>>>>>>>Today I discovered I could no longer create files on one of my boxes,
>>>>>>>which still runs 2.4.18 (box is too far away to upgrade right now). It
>>>>>>>gives me 'disk full' messages.
>>>>>>>
>>>>>>>The following message is all over my logs since January 3:
>>>>>>>
>>>>>>>vs-2120: add_save_link: insert_item returned -28
>>>>>>>         
>>>>>>>
>>>>>>>              
>>>>>>>
>>>>>>This is just a warning. You should be able to free some disk space by
>>>>>>removing some files.
>>>>>>
>>>>>>       
>>>>>>
>>>>>>            
>>>>>>
>>>>>>
>At this case we do not return ENOSPC. Operation which failed due to
>ENOSPC was "save link" insertion. The major operation (unlink or
>truncate) just continues without "save links". (save link are used to be
>able to complete removal of unlinked/truncated files on reboot if they
>did not manage to get properly removed/truncated due to unclean
>shutdown).
>
>
>
>
>
>  
>
so it is a real bug which can result in space leaks?

-- 
Hans

Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28

[Chris Mason]

On Fri, 2004-01-16 at 07:55, Hans Reiser wrote:

> >At this case we do not return ENOSPC. Operation which failed due to
> >ENOSPC was "save link" insertion. The major operation (unlink or
> >truncate) just continues without "save links". (save link are used to be
> >able to complete removal of unlinked/truncated files on reboot if they
> >did not manage to get properly removed/truncated due to unclean
> >shutdown).

> so it is a real bug which can result in space leaks?

It's a limitation.  The only way around it would be to somehow reserve
the space for the savelink when you create the file.  It's a rare case
and the FS carries on as best it can.

-chris

Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28

[Hans Reiser]

Chris Mason wrote:

>On Fri, 2004-01-16 at 07:55, Hans Reiser wrote:
>
>  
>
>>>At this case we do not return ENOSPC. Operation which failed due to
>>>ENOSPC was "save link" insertion. The major operation (unlink or
>>>truncate) just continues without "save links". (save link are used to be
>>>able to complete removal of unlinked/truncated files on reboot if they
>>>did not manage to get properly removed/truncated due to unclean
>>>shutdown).
>>>      
>>>
>
>  
>
>>so it is a real bug which can result in space leaks?
>>    
>>
>
>It's a limitation.  The only way around it would be to somehow reserve
>the space for the savelink when you create the file.  It's a rare case
>and the FS carries on as best it can.
>
>-chris
>
>
>
>
>  
>
does it leak space?

-- 
Hans

Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28

[Oleg Drokin]

Hello!

Hans Reiser <reiser@namesys.com> wrote:
>>>vs-2120: add_save_link: insert_item returned -28
>>This is just a warning. You should be able to free some disk space by
>>removing some files.
HR> why do we generate this warning?  It should be fixed, yes?

Yes, it is fixed in newer kernels.

Bye,
    Oleg

Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

On Fri, 16 Jan 2004 11:17:43 +0300, Vladimir Saveliev said:

> This is just a warning. You should be able to free some disk space by
> removing some files.

Is this just the *obvious* "removing files frees space", or is there some sort
of garbage collection that will be triggered, so removing a 1K file will make it
redo tables/linked lists/whatever and return lots of blocks that used to contain
metadata?

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28

[Vladimir Saveliev]

On Fri, 2004-01-16 at 19:19, Valdis.Kletnieks@vt.edu wrote:
> On Fri, 16 Jan 2004 11:17:43 +0300, Vladimir Saveliev said:
> 
> > This is just a warning. You should be able to free some disk space by
> > removing some files.
> 
> Is this just the *obvious* "removing files frees space", or is there some sort
> of garbage collection that will be triggered, so removing a 1K file will make it
> redo tables/linked lists/whatever and return lots of blocks that used to contain
> metadata?

This is the *obvious* "removing files frees space".