* [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28
@ 2004-01-09 15:22 Jan De Luyck
2004-01-09 17:00 ` Jan De Luyck
2004-01-16 8:17 ` Vladimir Saveliev
0 siblings, 2 replies; 14+ messages in thread
From: Jan De Luyck @ 2004-01-09 15:22 UTC (permalink / raw)
To: linux-kernel; +Cc: reiserfs-list
Hello list,
Today I discovered I could no longer create files on one of my boxes, which
still runs 2.4.18 (box is too far away to upgrade right now). It gives me
'disk full' messages.
The following message is all over my logs since January 3:
vs-2120: add_save_link: insert_item returned -28
I can't seem to find much on this issue, is this a bug in reiserfs (which is
fixed in a later version)? Is something wrong with the fs itself?
Thanks for answers.
[I'm not subscribed @ reiserfs-list, so please cc me with answers from that
list]
Jan
--
It is exactly because a man cannot do a thing that he is a proper judge of it.
-- Oscar Wilde
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28
2004-01-09 15:22 [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28 Jan De Luyck
@ 2004-01-09 17:00 ` Jan De Luyck
2004-01-16 8:17 ` Vladimir Saveliev
1 sibling, 0 replies; 14+ messages in thread
From: Jan De Luyck @ 2004-01-09 17:00 UTC (permalink / raw)
To: linux-kernel; +Cc: reiserfs-list
On Friday 09 January 2004 16:22, Jan De Luyck wrote:
> Hello list,
>
> Today I discovered I could no longer create files on one of my boxes, which
> still runs 2.4.18 (box is too far away to upgrade right now). It gives me
> 'disk full' messages.
>
> The following message is all over my logs since January 3:
>
> vs-2120: add_save_link: insert_item returned -28
>
> I can't seem to find much on this issue, is this a bug in reiserfs (which
> is fixed in a later version)? Is something wrong with the fs itself?
>
> Thanks for answers.
Nevermind this... I was looking at the wrong partition... for half an hour....
:-(
Jan
--
My apologies if I sound angry. I feel like I'm talking to a void.
-- Avery Pennarun
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28
2004-01-09 15:22 [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28 Jan De Luyck
2004-01-09 17:00 ` Jan De Luyck
@ 2004-01-16 8:17 ` Vladimir Saveliev
2004-01-16 8:48 ` Hans Reiser
2004-01-16 16:19 ` Valdis.Kletnieks
1 sibling, 2 replies; 14+ messages in thread
From: Vladimir Saveliev @ 2004-01-16 8:17 UTC (permalink / raw)
To: Jan De Luyck; +Cc: linux-kernel, reiserfs-list
Hello
On Fri, 2004-01-09 at 18:22, Jan De Luyck wrote:
> Hello list,
>
> Today I discovered I could no longer create files on one of my boxes, which
> still runs 2.4.18 (box is too far away to upgrade right now). It gives me
> 'disk full' messages.
>
> The following message is all over my logs since January 3:
>
> vs-2120: add_save_link: insert_item returned -28
>
This is just a warning. You should be able to free some disk space by
removing some files.
> I can't seem to find much on this issue, is this a bug in reiserfs (which is
> fixed in a later version)? Is something wrong with the fs itself?
>
> Thanks for answers.
>
> [I'm not subscribed @ reiserfs-list, so please cc me with answers from that
> list]
>
> Jan
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28
2004-01-16 8:17 ` Vladimir Saveliev
@ 2004-01-16 8:48 ` Hans Reiser
2004-01-16 9:11 ` Vladimir Saveliev
2004-01-16 15:52 ` Oleg Drokin
2004-01-16 16:19 ` Valdis.Kletnieks
1 sibling, 2 replies; 14+ messages in thread
From: Hans Reiser @ 2004-01-16 8:48 UTC (permalink / raw)
To: Vladimir Saveliev; +Cc: Jan De Luyck, linux-kernel, reiserfs-list
Vladimir Saveliev wrote:
>Hello
>
>On Fri, 2004-01-09 at 18:22, Jan De Luyck wrote:
>
>
>>Hello list,
>>
>>Today I discovered I could no longer create files on one of my boxes, which
>>still runs 2.4.18 (box is too far away to upgrade right now). It gives me
>>'disk full' messages.
>>
>>The following message is all over my logs since January 3:
>>
>>vs-2120: add_save_link: insert_item returned -28
>>
>>
>>
>
>This is just a warning. You should be able to free some disk space by
>removing some files.
>
>
>
>
>
>>I can't seem to find much on this issue, is this a bug in reiserfs (which is
>>fixed in a later version)? Is something wrong with the fs itself?
>>
>>Thanks for answers.
>>
>>[I'm not subscribed @ reiserfs-list, so please cc me with answers from that
>>list]
>>
>>Jan
>>
>>
>
>
>
>
>
why do we generate this warning? It should be fixed, yes?
--
Hans
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28
2004-01-16 8:48 ` Hans Reiser
@ 2004-01-16 9:11 ` Vladimir Saveliev
2004-01-16 11:29 ` Jan De Luyck
2004-01-16 15:52 ` Oleg Drokin
1 sibling, 1 reply; 14+ messages in thread
From: Vladimir Saveliev @ 2004-01-16 9:11 UTC (permalink / raw)
To: Hans Reiser; +Cc: Jan De Luyck, reiserfs-list
On Fri, 2004-01-16 at 11:48, Hans Reiser wrote:
> Vladimir Saveliev wrote:
>
> >Hello
> >
> >On Fri, 2004-01-09 at 18:22, Jan De Luyck wrote:
> >
> >
> >>Hello list,
> >>
> >>Today I discovered I could no longer create files on one of my boxes, which
> >>still runs 2.4.18 (box is too far away to upgrade right now). It gives me
> >>'disk full' messages.
> >>
> >>The following message is all over my logs since January 3:
> >>
> >>vs-2120: add_save_link: insert_item returned -28
> >>
> >>
> >>
> >
> >This is just a warning. You should be able to free some disk space by
> >removing some files.
> >
> >
> >
> >
> >
> >>I can't seem to find much on this issue, is this a bug in reiserfs (which is
> >>fixed in a later version)? Is something wrong with the fs itself?
> >>
> >>Thanks for answers.
> >>
> >>[I'm not subscribed @ reiserfs-list, so please cc me with answers from that
> >>list]
> >>
> >>Jan
> >>
> >>
> >
> >
> >
> >
> >
> why do we generate this warning? It should be fixed, yes?
Yes
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28
2004-01-16 9:11 ` Vladimir Saveliev
@ 2004-01-16 11:29 ` Jan De Luyck
2004-01-16 12:40 ` Hans Reiser
0 siblings, 1 reply; 14+ messages in thread
From: Jan De Luyck @ 2004-01-16 11:29 UTC (permalink / raw)
To: Vladimir Saveliev, Hans Reiser; +Cc: reiserfs-list
On Friday 16 January 2004 10:11, Vladimir Saveliev wrote:
> On Fri, 2004-01-16 at 11:48, Hans Reiser wrote:
> > Vladimir Saveliev wrote:
> > >Hello
> > >
> > >On Fri, 2004-01-09 at 18:22, Jan De Luyck wrote:
> > >>Hello list,
> > >>
> > >>Today I discovered I could no longer create files on one of my boxes,
> > >> which still runs 2.4.18 (box is too far away to upgrade right now). It
> > >> gives me 'disk full' messages.
> > >>
> > >>The following message is all over my logs since January 3:
> > >>
> > >>vs-2120: add_save_link: insert_item returned -28
> > >
> > >This is just a warning. You should be able to free some disk space by
> > >removing some files.
> > >
> > >>I can't seem to find much on this issue, is this a bug in reiserfs
> > >> (which is fixed in a later version)? Is something wrong with the fs
> > >> itself?
> > >>
> > >>Thanks for answers.
> > >>
> > >>[I'm not subscribed @ reiserfs-list, so please cc me with answers from
> > >> that list]
> > >>
> > >>Jan
> >
> > why do we generate this warning? It should be fixed, yes?
>
> Yes
Just returning a message that makes sense to people would be nice.
Jan
--
People think love is an emotion. Love is good sense.
-- Ken Kesey
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28
2004-01-16 11:29 ` Jan De Luyck
@ 2004-01-16 12:40 ` Hans Reiser
2004-01-16 12:50 ` Vladimir Saveliev
0 siblings, 1 reply; 14+ messages in thread
From: Hans Reiser @ 2004-01-16 12:40 UTC (permalink / raw)
To: Jan De Luyck; +Cc: Vladimir Saveliev, reiserfs-list
Jan De Luyck wrote:
>On Friday 16 January 2004 10:11, Vladimir Saveliev wrote:
>
>
>>On Fri, 2004-01-16 at 11:48, Hans Reiser wrote:
>>
>>
>>>Vladimir Saveliev wrote:
>>>
>>>
>>>>Hello
>>>>
>>>>On Fri, 2004-01-09 at 18:22, Jan De Luyck wrote:
>>>>
>>>>
>>>>>Hello list,
>>>>>
>>>>>Today I discovered I could no longer create files on one of my boxes,
>>>>>which still runs 2.4.18 (box is too far away to upgrade right now). It
>>>>>gives me 'disk full' messages.
>>>>>
>>>>>The following message is all over my logs since January 3:
>>>>>
>>>>>vs-2120: add_save_link: insert_item returned -28
>>>>>
>>>>>
>>>>This is just a warning. You should be able to free some disk space by
>>>>removing some files.
>>>>
>>>>
>>>>
>>>>>I can't seem to find much on this issue, is this a bug in reiserfs
>>>>>(which is fixed in a later version)? Is something wrong with the fs
>>>>>itself?
>>>>>
>>>>>Thanks for answers.
>>>>>
>>>>>[I'm not subscribed @ reiserfs-list, so please cc me with answers from
>>>>>that list]
>>>>>
>>>>>Jan
>>>>>
>>>>>
>>>why do we generate this warning? It should be fixed, yes?
>>>
>>>
>>Yes
>>
>>
>
>Just returning a message that makes sense to people would be nice.
>
>Jan
>
>
>
there is no need for a warning at all, it is a normal condition, and
returning ENOSPACE says all that we should say.
--
Hans
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28
2004-01-16 12:40 ` Hans Reiser
@ 2004-01-16 12:50 ` Vladimir Saveliev
2004-01-16 12:55 ` Hans Reiser
0 siblings, 1 reply; 14+ messages in thread
From: Vladimir Saveliev @ 2004-01-16 12:50 UTC (permalink / raw)
To: Hans Reiser; +Cc: Jan De Luyck, reiserfs-list
On Fri, 2004-01-16 at 15:40, Hans Reiser wrote:
> Jan De Luyck wrote:
>
> >On Friday 16 January 2004 10:11, Vladimir Saveliev wrote:
> >
> >
> >>On Fri, 2004-01-16 at 11:48, Hans Reiser wrote:
> >>
> >>
> >>>Vladimir Saveliev wrote:
> >>>
> >>>
> >>>>Hello
> >>>>
> >>>>On Fri, 2004-01-09 at 18:22, Jan De Luyck wrote:
> >>>>
> >>>>
> >>>>>Hello list,
> >>>>>
> >>>>>Today I discovered I could no longer create files on one of my boxes,
> >>>>>which still runs 2.4.18 (box is too far away to upgrade right now). It
> >>>>>gives me 'disk full' messages.
> >>>>>
> >>>>>The following message is all over my logs since January 3:
> >>>>>
> >>>>>vs-2120: add_save_link: insert_item returned -28
> >>>>>
> >>>>>
> >>>>This is just a warning. You should be able to free some disk space by
> >>>>removing some files.
> >>>>
> >>>>
> >>>>
> >>>>>I can't seem to find much on this issue, is this a bug in reiserfs
> >>>>>(which is fixed in a later version)? Is something wrong with the fs
> >>>>>itself?
> >>>>>
> >>>>>Thanks for answers.
> >>>>>
> >>>>>[I'm not subscribed @ reiserfs-list, so please cc me with answers from
> >>>>>that list]
> >>>>>
> >>>>>Jan
> >>>>>
> >>>>>
> >>>why do we generate this warning? It should be fixed, yes?
> >>>
> >>>
> >>Yes
> >>
> >>
> >
> >Just returning a message that makes sense to people would be nice.
> >
> >Jan
> >
> >
> >
> there is no need for a warning at all, it is a normal condition, and
> returning ENOSPACE says all that we should say.
At this case we do not return ENOSPC. Operation which failed due to
ENOSPC was "save link" insertion. The major operation (unlink or
truncate) just continues without "save links". (save link are used to be
able to complete removal of unlinked/truncated files on reboot if they
did not manage to get properly removed/truncated due to unclean
shutdown).
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28
2004-01-16 12:50 ` Vladimir Saveliev
@ 2004-01-16 12:55 ` Hans Reiser
2004-01-16 13:29 ` Chris Mason
0 siblings, 1 reply; 14+ messages in thread
From: Hans Reiser @ 2004-01-16 12:55 UTC (permalink / raw)
To: Vladimir Saveliev; +Cc: Jan De Luyck, reiserfs-list
Vladimir Saveliev wrote:
>On Fri, 2004-01-16 at 15:40, Hans Reiser wrote:
>
>
>>Jan De Luyck wrote:
>>
>>
>>
>>>On Friday 16 January 2004 10:11, Vladimir Saveliev wrote:
>>>
>>>
>>>
>>>
>>>>On Fri, 2004-01-16 at 11:48, Hans Reiser wrote:
>>>>
>>>>
>>>>
>>>>
>>>>>Vladimir Saveliev wrote:
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>>Hello
>>>>>>
>>>>>>On Fri, 2004-01-09 at 18:22, Jan De Luyck wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>>Hello list,
>>>>>>>
>>>>>>>Today I discovered I could no longer create files on one of my boxes,
>>>>>>>which still runs 2.4.18 (box is too far away to upgrade right now). It
>>>>>>>gives me 'disk full' messages.
>>>>>>>
>>>>>>>The following message is all over my logs since January 3:
>>>>>>>
>>>>>>>vs-2120: add_save_link: insert_item returned -28
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>This is just a warning. You should be able to free some disk space by
>>>>>>removing some files.
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>At this case we do not return ENOSPC. Operation which failed due to
>ENOSPC was "save link" insertion. The major operation (unlink or
>truncate) just continues without "save links". (save link are used to be
>able to complete removal of unlinked/truncated files on reboot if they
>did not manage to get properly removed/truncated due to unclean
>shutdown).
>
>
>
>
>
>
>
so it is a real bug which can result in space leaks?
--
Hans
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28
2004-01-16 12:55 ` Hans Reiser
@ 2004-01-16 13:29 ` Chris Mason
2004-01-16 13:29 ` Hans Reiser
0 siblings, 1 reply; 14+ messages in thread
From: Chris Mason @ 2004-01-16 13:29 UTC (permalink / raw)
To: Hans Reiser; +Cc: Vladimir Saveliev, Jan De Luyck, reiserfs-list
On Fri, 2004-01-16 at 07:55, Hans Reiser wrote:
> >At this case we do not return ENOSPC. Operation which failed due to
> >ENOSPC was "save link" insertion. The major operation (unlink or
> >truncate) just continues without "save links". (save link are used to be
> >able to complete removal of unlinked/truncated files on reboot if they
> >did not manage to get properly removed/truncated due to unclean
> >shutdown).
> so it is a real bug which can result in space leaks?
It's a limitation. The only way around it would be to somehow reserve
the space for the savelink when you create the file. It's a rare case
and the FS carries on as best it can.
-chris
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28
2004-01-16 13:29 ` Chris Mason
@ 2004-01-16 13:29 ` Hans Reiser
0 siblings, 0 replies; 14+ messages in thread
From: Hans Reiser @ 2004-01-16 13:29 UTC (permalink / raw)
To: Chris Mason; +Cc: Vladimir Saveliev, Jan De Luyck, reiserfs-list
Chris Mason wrote:
>On Fri, 2004-01-16 at 07:55, Hans Reiser wrote:
>
>
>
>>>At this case we do not return ENOSPC. Operation which failed due to
>>>ENOSPC was "save link" insertion. The major operation (unlink or
>>>truncate) just continues without "save links". (save link are used to be
>>>able to complete removal of unlinked/truncated files on reboot if they
>>>did not manage to get properly removed/truncated due to unclean
>>>shutdown).
>>>
>>>
>
>
>
>>so it is a real bug which can result in space leaks?
>>
>>
>
>It's a limitation. The only way around it would be to somehow reserve
>the space for the savelink when you create the file. It's a rare case
>and the FS carries on as best it can.
>
>-chris
>
>
>
>
>
>
does it leak space?
--
Hans
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28
2004-01-16 8:48 ` Hans Reiser
2004-01-16 9:11 ` Vladimir Saveliev
@ 2004-01-16 15:52 ` Oleg Drokin
1 sibling, 0 replies; 14+ messages in thread
From: Oleg Drokin @ 2004-01-16 15:52 UTC (permalink / raw)
To: reiser, linux-kernel
Hello!
Hans Reiser <reiser@namesys.com> wrote:
>>>vs-2120: add_save_link: insert_item returned -28
>>This is just a warning. You should be able to free some disk space by
>>removing some files.
HR> why do we generate this warning? It should be fixed, yes?
Yes, it is fixed in newer kernels.
Bye,
Oleg
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28
2004-01-16 8:17 ` Vladimir Saveliev
2004-01-16 8:48 ` Hans Reiser
@ 2004-01-16 16:19 ` Valdis.Kletnieks
2004-01-16 16:26 ` Vladimir Saveliev
1 sibling, 1 reply; 14+ messages in thread
From: Valdis.Kletnieks @ 2004-01-16 16:19 UTC (permalink / raw)
To: Vladimir Saveliev; +Cc: Jan De Luyck, linux-kernel, reiserfs-list
[-- Attachment #1: Type: text/plain, Size: 408 bytes --]
On Fri, 16 Jan 2004 11:17:43 +0300, Vladimir Saveliev said:
> This is just a warning. You should be able to free some disk space by
> removing some files.
Is this just the *obvious* "removing files frees space", or is there some sort
of garbage collection that will be triggered, so removing a 1K file will make it
redo tables/linked lists/whatever and return lots of blocks that used to contain
metadata?
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28
2004-01-16 16:19 ` Valdis.Kletnieks
@ 2004-01-16 16:26 ` Vladimir Saveliev
0 siblings, 0 replies; 14+ messages in thread
From: Vladimir Saveliev @ 2004-01-16 16:26 UTC (permalink / raw)
To: Valdis.Kletnieks; +Cc: Jan De Luyck, linux-kernel, reiserfs-list
On Fri, 2004-01-16 at 19:19, Valdis.Kletnieks@vt.edu wrote:
> On Fri, 16 Jan 2004 11:17:43 +0300, Vladimir Saveliev said:
>
> > This is just a warning. You should be able to free some disk space by
> > removing some files.
>
> Is this just the *obvious* "removing files frees space", or is there some sort
> of garbage collection that will be triggered, so removing a 1K file will make it
> redo tables/linked lists/whatever and return lots of blocks that used to contain
> metadata?
This is the *obvious* "removing files frees space".
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2004-01-16 16:26 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-09 15:22 [2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28 Jan De Luyck
2004-01-09 17:00 ` Jan De Luyck
2004-01-16 8:17 ` Vladimir Saveliev
2004-01-16 8:48 ` Hans Reiser
2004-01-16 9:11 ` Vladimir Saveliev
2004-01-16 11:29 ` Jan De Luyck
2004-01-16 12:40 ` Hans Reiser
2004-01-16 12:50 ` Vladimir Saveliev
2004-01-16 12:55 ` Hans Reiser
2004-01-16 13:29 ` Chris Mason
2004-01-16 13:29 ` Hans Reiser
2004-01-16 15:52 ` Oleg Drokin
2004-01-16 16:19 ` Valdis.Kletnieks
2004-01-16 16:26 ` Vladimir Saveliev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.