* fix ppc compile
@ 2004-03-16 21:05 Dave Jones
2004-03-16 21:20 ` Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2004-03-16 21:05 UTC (permalink / raw)
To: Linux Kernel
2.6.5rc1 changes this function, but there is no 'dev' argument there.
This makes it look a little more sane, but I've no hardware to test it on.
Dave
--- linux-2.6.4/arch/ppc/syslib/indirect_pci.c~ 2004-03-16 21:03:20.000000000 +0000
+++ linux-2.6.4/arch/ppc/syslib/indirect_pci.c 2004-03-16 21:03:31.000000000 +0000
@@ -44,8 +44,8 @@
cfg_type = 1;
PCI_CFG_OUT(hose->cfg_addr,
- (0x80000000 | ((dev->bus->number - hose->bus_offset) << 16)
- | (dev->devfn << 8) | ((offset & 0xfc) | cfg_type)));
+ (0x80000000 | ((bus->number - hose->bus_offset) << 16)
+ | (devfn << 8) | ((offset & 0xfc) | cfg_type)));
/*
* Note: the caller has already checked that offset is
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: fix ppc compile
2004-03-16 21:05 fix ppc compile Dave Jones
@ 2004-03-16 21:20 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2004-03-16 21:20 UTC (permalink / raw)
To: Dave Jones, Linux Kernel
On Tue, Mar 16, 2004 at 09:05:40PM +0000, Dave Jones wrote:
> 2.6.5rc1 changes this function, but there is no 'dev' argument there.
> This makes it look a little more sane, but I've no hardware to test it on.
>
> Dave
>
> --- linux-2.6.4/arch/ppc/syslib/indirect_pci.c~ 2004-03-16 21:03:20.000000000 +0000
> +++ linux-2.6.4/arch/ppc/syslib/indirect_pci.c 2004-03-16 21:03:31.000000000 +0000
> @@ -44,8 +44,8 @@
> cfg_type = 1;
>
> PCI_CFG_OUT(hose->cfg_addr,
> - (0x80000000 | ((dev->bus->number - hose->bus_offset) << 16)
> - | (dev->devfn << 8) | ((offset & 0xfc) | cfg_type)));
> + (0x80000000 | ((bus->number - hose->bus_offset) << 16)
> + | (devfn << 8) | ((offset & 0xfc) | cfg_type)));
>
> /*
> * Note: the caller has already checked that offset is
There's this problem in 2 places. I've sent akpm a patch already that
fixes 'em both.
--
Tom Rini
http://gate.crashing.org/~trini/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-03-16 21:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-03-16 21:05 fix ppc compile Dave Jones
2004-03-16 21:20 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.