grub fails to tftp a file with more than 64K blocks

grub fails to tftp a file with more than 64K blocks

[Guzovsky, Eduard]

[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]

Grub version 0.94 with (or without) "grub-0[1].94-diskless-1.patch"
fails to tftp a file with more than 64K blocks. Bellow is a fix. Note
that the bug exists in buf_fill() function. 

"grub-0[1].94-diskless-1.patch" has identical code in tftp_file_read()
function which does not have this problem.

 

-Ed

 

 

*** grub-0.94/netboot/fsys_tftp.c   Tue Apr 13 15:48:25 2004

--- grub-0.94.orig/netboot/fsys_tftp.c Thu Apr 8 15:45:37 2004

***************

*** 375,381 ****

      /* Neither TFTP_OACK nor TFTP_DATA.  */

      break;

  

!     if ((block || bcounter) && (block != (unsigned short)(prevblock +
1)))

      /* Block order should be continuous */

      tp.u.ack.block = htons (block = prevblock);

        

--- 375,381 ----

      /* Neither TFTP_OACK nor TFTP_DATA.  */

      break;

  

!     if ((block || bcounter) && (block != prevblock + 1))

      /* Block order should be continuous */

      tp.u.ack.block = htons (block = prevblock);

        


[-- Attachment #2: Type: text/html, Size: 5716 bytes --]

Re: grub fails to tftp a file with more than 64K blocks

[Yoshinori K. Okuji]

On Wednesday 14 April 2004 04:39, Guzovsky, Eduard wrote:
> Grub version 0.94 with (or without) "grub-0[1].94-diskless-1.patch"
> fails to tftp a file with more than 64K blocks. Bellow is a fix. Note
> that the bug exists in buf_fill() function.

Thanks for your contribution, but this is not the right place to send 
your patch. grub-devel is used for GRUB 2 but not for GRUB legacy. 
bug-grub is used for patches against GRUB legacy instead.

This time, I accept your patch here, but please use bug-grub rather than 
grub-devel from now on.

Also, I'd like you to read the instructions on how to send patches in 
the manual. It should say that:

1. Unified format is desirable as a diff format.
2. Reverse patches are not good.
3. You should write a ChangeLog entry for your change.

Okuji

RE: grub fails to tftp a file with more than 64K blocks

[Guzovsky, Eduard]

Thanks. I did not realize the bug-grub mailing list is for the patches.
I'll follow the rules next time.

-Ed


-----Original Message-----
From: grub-devel-bounces+eguzovsk=enterasys.com@gnu.org
[mailto:grub-devel-bounces+eguzovsk=enterasys.com@gnu.org] On Behalf Of
Yoshinori K. Okuji
Sent: Thursday, April 15, 2004 7:37 AM
To: The development of GRUB 2
Subject: Re: grub fails to tftp a file with more than 64K blocks

On Wednesday 14 April 2004 04:39, Guzovsky, Eduard wrote:
> Grub version 0.94 with (or without) "grub-0[1].94-diskless-1.patch"
> fails to tftp a file with more than 64K blocks. Bellow is a fix. Note
> that the bug exists in buf_fill() function.

Thanks for your contribution, but this is not the right place to send 
your patch. grub-devel is used for GRUB 2 but not for GRUB legacy. 
bug-grub is used for patches against GRUB legacy instead.

This time, I accept your patch here, but please use bug-grub rather than

grub-devel from now on.

Also, I'd like you to read the instructions on how to send patches in 
the manual. It should say that:

1. Unified format is desirable as a diff format.
2. Reverse patches are not good.
3. You should write a ChangeLog entry for your change.

Okuji



_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/grub-devel