All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Domsch <Matt_Domsch@dell.com>
To: Sourav Sen <souravs@india.hp.com>
Cc: matthew.e.tolentino@intel.com, linux-ia64@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [2.6.6 PATCH] Exposing EFI memory map
Date: Thu, 06 May 2004 12:46:49 +0000	[thread overview]
Message-ID: <20040506124649.GA13482@lists.us.dell.com> (raw)
In-Reply-To: <003801c43347$812a1590$39624c0f@india.hp.com>

[-- Attachment #1: Type: text/plain, Size: 902 bytes --]

On Thu, May 06, 2004 at 02:22:46PM +0530, Sourav Sen wrote:
> The following simple patch creates a read-only file
> "memmap" under <mount point>/firmware/efi/ in sysfs
> and exposes the efi memory map thru it.

I'm not generally opposed, but have a couple questions.

1) Why does userspace / humans need to know this?  For debugging firmware?

2) Can the memory map output ever be larger than PAGE_SIZE (lower
limit is 4KB on x86)?  If not, what guarantees that?  If so, you need
your own read mechanism rather than the generic sysfs one.

The one-value-per-file rule has an exception for an array of values of
the same type per Documentation/filesystems/sysfs.txt, which this
looks to adhere to.

Thanks,
Matt

-- 
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Matt Domsch <Matt_Domsch@dell.com>
To: Sourav Sen <souravs@india.hp.com>
Cc: matthew.e.tolentino@intel.com, linux-ia64@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [2.6.6 PATCH] Exposing EFI memory map
Date: Thu, 6 May 2004 07:46:49 -0500	[thread overview]
Message-ID: <20040506124649.GA13482@lists.us.dell.com> (raw)
In-Reply-To: <003801c43347$812a1590$39624c0f@india.hp.com>

[-- Attachment #1: Type: text/plain, Size: 902 bytes --]

On Thu, May 06, 2004 at 02:22:46PM +0530, Sourav Sen wrote:
> The following simple patch creates a read-only file
> "memmap" under <mount point>/firmware/efi/ in sysfs
> and exposes the efi memory map thru it.

I'm not generally opposed, but have a couple questions.

1) Why does userspace / humans need to know this?  For debugging firmware?

2) Can the memory map output ever be larger than PAGE_SIZE (lower
limit is 4KB on x86)?  If not, what guarantees that?  If so, you need
your own read mechanism rather than the generic sysfs one.

The one-value-per-file rule has an exception for an array of values of
the same type per Documentation/filesystems/sysfs.txt, which this
looks to adhere to.

Thanks,
Matt

-- 
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2004-05-06 12:46 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-06  8:52 [2.6.6 PATCH] Exposing EFI memory map Sourav Sen
2004-05-06  8:53 ` Sourav Sen
2004-05-06 10:44 ` Christoph Hellwig
2004-05-06 10:44   ` Christoph Hellwig
2004-05-06 11:59   ` Matthew Wilcox
2004-05-06 11:59     ` Matthew Wilcox
2004-05-06 12:18     ` Arjan van de Ven
2004-05-06 12:18       ` Arjan van de Ven
2004-05-06 13:27       ` Matthew Wilcox
2004-05-06 13:27         ` Matthew Wilcox
2004-05-06 14:00         ` Dave Hansen
2004-05-06 14:00           ` Dave Hansen
2004-05-06 14:09           ` Arjan van de Ven
2004-05-06 14:09             ` Arjan van de Ven
2004-05-06 14:09     ` Christoph Hellwig
2004-05-06 14:09       ` Christoph Hellwig
2004-05-06 12:46 ` Matt Domsch [this message]
2004-05-06 12:46   ` Matt Domsch
2004-05-06 13:20   ` Sourav Sen
2004-05-06 13:32     ` Sourav Sen
2004-05-06 15:08     ` Bjorn Helgaas
2004-05-06 15:08       ` Bjorn Helgaas
2004-05-06 16:25       ` Sourav Sen
2004-05-06 16:37         ` Sourav Sen
2004-05-06 16:49         ` Dave Hansen
2004-05-06 16:49           ` Dave Hansen
2004-05-06 13:23 ` Luck, Tony
2004-05-06 13:23   ` Luck, Tony
2004-05-06 16:14 ` Tolentino, Matthew E
2004-05-06 16:14   ` Tolentino, Matthew E
2004-05-06 16:40 ` Greg KH
2004-05-06 16:40   ` Greg KH
2004-05-07  9:45   ` Sourav Sen
2004-05-07  9:57     ` Sourav Sen
2004-05-07 21:49     ` Greg KH
2004-05-07 21:49       ` Greg KH
2004-05-11 14:44       ` Sourav Sen
2004-05-11 14:56         ` Sourav Sen
2004-05-11 15:42         ` Dave Hansen
2004-05-11 15:42           ` Dave Hansen
2004-05-12 10:24           ` Sourav Sen
2004-05-12 10:36             ` Sourav Sen
2004-05-12 16:15             ` Dave Hansen
2004-05-12 16:15               ` Dave Hansen
2004-05-13 14:10               ` Sourav Sen
2004-05-13 14:22                 ` Sourav Sen
2004-05-13 15:32                 ` Dave Hansen
2004-05-13 15:32                   ` Dave Hansen
2004-05-06 18:47 ` Tolentino, Matthew E
2004-05-06 18:47   ` Tolentino, Matthew E
2004-05-06 18:57   ` Dave Hansen
2004-05-06 18:57     ` Dave Hansen
2004-05-06 20:54 ` Tolentino, Matthew E
2004-05-06 20:54   ` Tolentino, Matthew E
2004-05-06 21:44   ` [Lhms-devel] " Dave Hansen
2004-05-06 21:44     ` Dave Hansen
  -- strict thread matches above, loose matches on Subject: below --
2004-05-06  9:18 Sourav Sen
2004-05-06  9:30 ` Sourav Sen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040506124649.GA13482@lists.us.dell.com \
    --to=matt_domsch@dell.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.e.tolentino@intel.com \
    --cc=souravs@india.hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.