[Kernel-janitors] Re: Replaces yield() with nicedelay() on

[Kernel-janitors] Re: Replaces yield() with nicedelay() on

[Domen Puncer]

[-- Attachment #1: Type: text/plain, Size: 1507 bytes --]

On 02/05/04 22:24 -0300, Gustavo Franco wrote:
> Hi,
> 
> It's the last REDIFF, but i'm not replacing yield() with 
> schedule_timeout() because there's a nicedelay() (maybe the
> usecs need to be tuned below) there:
> 
> 
> static inline void nicedelay(unsigned long usecs)
> {
>         current->state = TASK_INTERRUPTIBLE;
>         schedule_timeout(HZ);
>         return;
> }

And usecs stands for??
Funny thing is that there are actualy uses of this function.

Also, please make -p1 applyable patches.

> 
> Hope that helps,
> Gustavo Franco
> 
> --- drivers/net/sb1000.c.orig   2004-04-28 20:50:17.000000000 -0300
> +++ drivers/net/sb1000.c        2004-04-28 20:49:10.000000000 -0300
> @@ -271,7 +271,7 @@
>         timeout = jiffies + TimeOutJiffies;
>         while (a & 0x80 || a & 0x40) {
>                 /* a little sleep */
> -               yield();
> +               nicedelay(10000);
> 
> 
>                 a = inb(ioaddr[0] + 7);
>                 if (time_after_eq(jiffies, timeout)) {
> @@ -295,7 +295,7 @@
>         timeout = jiffies + TimeOutJiffies;
>         while (a & 0x80 || !(a & 0x40)) {
>                 /* a little sleep */
> -               yield();
> +               nicedelay(10000);
> 
> 
>                 a = inb(ioaddr[1] + 6);
>                 if (time_after_eq(jiffies, timeout)) {
> 
> 
> 

> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> http://lists.osdl.org/mailman/listinfo/kernel-janitors


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] Re: Replaces yield() with nicedelay() on

[Greg KH]

[-- Attachment #1: Type: text/plain, Size: 666 bytes --]

On Mon, May 24, 2004 at 03:24:40PM +0200, Domen Puncer wrote:
> On 02/05/04 22:24 -0300, Gustavo Franco wrote:
> > Hi,
> > 
> > It's the last REDIFF, but i'm not replacing yield() with 
> > schedule_timeout() because there's a nicedelay() (maybe the
> > usecs need to be tuned below) there:
> > 
> > 
> > static inline void nicedelay(unsigned long usecs)
> > {
> >         current->state = TASK_INTERRUPTIBLE;
> >         schedule_timeout(HZ);
> >         return;
> > }
> 
> And usecs stands for??
> Funny thing is that there are actualy uses of this function.

Heh, also look at using the msleep function instead of redefining your
own function.

thanks,

greg k-h

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] Re: Replaces yield() with nicedelay() on

[Gustavo Franco]

[-- Attachment #1: Type: text/plain, Size: 835 bytes --]

Greg KH wrote:
> On Mon, May 24, 2004 at 03:24:40PM +0200, Domen Puncer wrote:
> 
>>On 02/05/04 22:24 -0300, Gustavo Franco wrote:
>>
>>>Hi,
>>>
>>>It's the last REDIFF, but i'm not replacing yield() with 
>>>schedule_timeout() because there's a nicedelay() (maybe the
>>>usecs need to be tuned below) there:
>>>
>>>
>>>static inline void nicedelay(unsigned long usecs)
>>>{
>>>        current->state = TASK_INTERRUPTIBLE;
>>>        schedule_timeout(HZ);
>>>        return;
>>>}
>>
>>And usecs stands for??
>>Funny thing is that there are actualy uses of this function.

Yes, it's not my piece of code.

> Heh, also look at using the msleep function instead of redefining your
> own function.
> 

Are you recommending to use msleep() instead schedule_timeout() to 
replace yield() ? Only in some cases? What?


Thanks,
Gustavo Franco

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] Re: Replaces yield() with nicedelay() on

[Gustavo Franco]

[-- Attachment #1: Type: text/plain, Size: 817 bytes --]

Domen Puncer wrote:
> On 02/05/04 22:24 -0300, Gustavo Franco wrote:
> 
>>Hi,
>>
>>It's the last REDIFF, but i'm not replacing yield() with 
>>schedule_timeout() because there's a nicedelay() (maybe the
>>usecs need to be tuned below) there:
>>
>>
>>static inline void nicedelay(unsigned long usecs)
>>{
>>        current->state = TASK_INTERRUPTIBLE;
>>        schedule_timeout(HZ);
>>        return;
>>}
> 
> 
> And usecs stands for??
> Funny thing is that there are actualy uses of this function.

What do you think about msleep() as greg said?

> Also, please make -p1 applyable patches.

I'm preparing my travel to debconf4, i'll be back on 30 May.In
early June i'll send rediffied patches.As i said in a previous
post it was my error.I was still considering the "old" SubmittingPatches.


Thanks,
Gustavo Franco

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] Re: Replaces yield() with nicedelay() on

[Domen Puncer]

[-- Attachment #1: Type: text/plain, Size: 1179 bytes --]

On 24/05/04 21:49 -0300, Gustavo Franco wrote:
> Domen Puncer wrote:
> >On 02/05/04 22:24 -0300, Gustavo Franco wrote:
> >
> >>Hi,
> >>
> >>It's the last REDIFF, but i'm not replacing yield() with 
> >>schedule_timeout() because there's a nicedelay() (maybe the
> >>usecs need to be tuned below) there:
> >>
> >>
> >>static inline void nicedelay(unsigned long usecs)
> >>{
> >>       current->state = TASK_INTERRUPTIBLE;
> >>       schedule_timeout(HZ);
> >>       return;
> >>}
> >
> >
> >And usecs stands for??
> >Funny thing is that there are actualy uses of this function.
> 
> What do you think about msleep() as greg said?

msleep is definitely the way to go, it includes set_current_state, and
is more readable.

> >Also, please make -p1 applyable patches.
> 
> I'm preparing my travel to debconf4, i'll be back on 30 May.In
> early June i'll send rediffied patches.As i said in a previous
> post it was my error.I was still considering the "old" SubmittingPatches.
> 
> 
> Thanks,
> Gustavo Franco

> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> http://lists.osdl.org/mailman/listinfo/kernel-janitors


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors