From: Tom Rini <trini@kernel.crashing.org>
To: Olaf Hering <olh@suse.de>
Cc: Andrew Morton <akpm@osdl.org>, linuxppc-dev@lists.linuxppc.org
Subject: Re: [PATCH] fix missing option in binutils version check
Date: Tue, 15 Jun 2004 09:12:58 -0700 [thread overview]
Message-ID: <20040615161258.GA14528@smtp.west.cox.net> (raw)
In-Reply-To: <20040614211931.GA21113@suse.de>
On Mon, Jun 14, 2004 at 11:19:31PM +0200, Olaf Hering wrote:
> On Mon, Jun 14, Tom Rini wrote:
>
> > ... except that we can have 'dssall' even when CONFIG_ALTIVEC=n, so we
> > need it really on CONFIG_6xx.
>
> switch_mm() has it in CONFIG_ALTIVEC, so checking for CONFIG_ALTIVEC=y
> looks correct to me.
arch/ppc/kernel/l2cr.S unconditionally has 'dssall', and this file is
compiled on all CONFIG_6xx builds.
> > But more importantly, why did you break the check to stop people with
> > broken binutils from trying to compile the kernel, and not fix the rest
> > of the breakage ?
>
> What exactly is broken in the old binutils?
They do not understand 'dssall' (and a few other) instructions. So in
2.4 we didn't call them directly, but had something along the lines of:
#ifndef DSSALL
#define DSSALL 0x........
#endif
Using dssall was just a choice of convenience.
--
Tom Rini
http://gate.crashing.org/~trini/
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2004-06-15 16:12 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-05 7:43 [PATCH] fix typo in binutils version check Olaf Hering
2004-06-05 10:40 ` Christian Kujau
2004-06-05 11:11 ` Olaf Hering
2004-06-05 13:11 ` Christian Kujau
2004-06-07 15:57 ` Tom Rini
2004-06-08 11:25 ` [PATCH] fix missing option " Olaf Hering
2004-06-10 0:16 ` Tom Rini
2004-06-14 9:15 ` Olaf Hering
2004-06-14 16:23 ` Tom Rini
2004-06-14 17:38 ` Olaf Hering
2004-06-14 18:07 ` Olaf Hering
2004-06-14 20:55 ` Tom Rini
2004-06-14 21:19 ` Olaf Hering
2004-06-15 16:12 ` Tom Rini [this message]
2004-06-15 17:25 ` Olaf Hering
2004-06-15 17:46 ` Tom Rini
2004-07-03 22:29 ` Olaf Hering
2004-07-04 1:30 ` Stef Simoens
2004-07-04 2:41 ` Tom Rini
2004-07-04 8:32 ` Geert Uytterhoeven
2004-07-04 16:33 ` Hollis Blanchard
2004-07-25 6:07 ` Alan Modra
2004-07-26 19:36 ` Tom Rini
2004-07-26 23:03 ` Alan Modra
2004-07-26 23:07 ` Tom Rini
2004-07-04 18:32 ` Tom Rini
2004-07-04 7:23 ` Olaf Hering
2004-07-05 18:32 ` Tom Rini
2004-07-09 1:34 ` Tom Rini
2004-07-09 1:43 ` Tom Rini
2004-07-12 9:06 ` Olaf Hering
2004-07-12 15:11 ` Tom Rini
2004-07-12 18:03 ` Tom Rini
2004-07-13 13:49 ` Olaf Hering
2004-07-13 14:01 ` Tom Rini
2004-07-13 14:02 ` Olaf Hering
2004-07-13 14:20 ` Tom Rini
2004-07-13 15:18 ` Olaf Hering
2004-07-13 15:26 ` Tom Rini
2004-07-13 15:29 ` Olaf Hering
2004-07-13 19:45 ` Tom Rini
2004-07-14 23:23 ` Tom Rini
2004-07-15 7:54 ` Geert Uytterhoeven
2004-07-15 12:50 ` Olaf Hering
2004-07-15 14:15 ` Tom Rini
2004-07-15 14:24 ` Olaf Hering
2004-07-15 14:23 ` Tom Rini
2004-07-05 18:18 ` Tom Rini
-- strict thread matches above, loose matches on Subject: below --
2004-06-10 16:19 Christian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040615161258.GA14528@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.