From: William Lee Irwin III <wli@holomorphy.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
David Gibson <david@gibson.dropbear.id.au>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: [BUG] hugetlb MAP_PRIVATE mapping vs /dev/zero
Date: Thu, 1 Jul 2004 09:56:55 -0700 [thread overview]
Message-ID: <20040701165655.GA21066@holomorphy.com> (raw)
In-Reply-To: <40E43BDE.85C5D670@tv-sign.ru>
On Thu, Jul 01, 2004 at 08:29:18PM +0400, Oleg Nesterov wrote:
> Hugetlbfs mmap with MAP_PRIVATE becomes MAP_SHARED
> silently, but vma->vm_flags have no VM_SHARED bit.
> I think it make sense to forbid MAP_PRIVATE in
> hugetlbfs_file_mmap() because it may confuse user
> space applications. But the real bug is that reading
> from /dev/zero into hugetlb will do:
> read_zero()
> read_zero_pagealigned()
> if (vma->vm_flags & VM_SHARED)
> break; // OK if MAP_PRIVATE
> zap_page_range();
> zeromap_page_range();
> We can fix hugetlbfs_file_mmap() or read_zero_pagealigned()
> or both.
Best to fix hugetlbfs_file_mmap().
-- wli
next prev parent reply other threads:[~2004-07-01 17:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-01 16:29 [BUG] hugetlb MAP_PRIVATE mapping vs /dev/zero Oleg Nesterov
2004-07-01 16:56 ` William Lee Irwin III [this message]
2004-07-01 21:55 ` Andrew Morton
2004-07-02 1:20 ` David Gibson
2004-07-02 2:44 ` William Lee Irwin III
2004-07-02 3:49 ` David Gibson
2004-07-02 4:12 ` David Gibson
2004-07-02 4:21 ` William Lee Irwin III
-- strict thread matches above, loose matches on Subject: below --
2004-07-02 12:12 Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040701165655.GA21066@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@osdl.org \
--cc=david@gibson.dropbear.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.