From: David Gibson <david@gibson.dropbear.id.au>
To: William Lee Irwin III <wli@holomorphy.com>,
Oleg Nesterov <oleg@tv-sign.ru>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: [BUG] hugetlb MAP_PRIVATE mapping vs /dev/zero
Date: Fri, 2 Jul 2004 13:49:37 +1000 [thread overview]
Message-ID: <20040702034937.GE5937@zax> (raw)
In-Reply-To: <20040702024422.GG21066@holomorphy.com>
On Thu, Jul 01, 2004 at 07:44:22PM -0700, William Lee Irwin wrote:
> On Thu, Jul 01, 2004 at 08:29:18PM +0400, Oleg Nesterov wrote:
> >> We can fix hugetlbfs_file_mmap() or read_zero_pagealigned()
> >> or both.
>
> On Fri, Jul 02, 2004 at 11:20:12AM +1000, David Gibson wrote:
> > Err... surely we need to fix both, yes?
>
> No. /dev/zero is innocent. hugetlb is demanding VM_SHARED semantics
> without actually setting VM_SHARED. /dev/zero tripping over its
> nonstandard pagetable structure is not something to be dealt with
> in /dev/zero itself.
Duh, sorry, misread the sense of the VM_SHARED test in the zeromap
code.
--
David Gibson | For every complex problem there is a
david AT gibson.dropbear.id.au | solution which is simple, neat and
| wrong.
http://www.ozlabs.org/people/dgibson
next prev parent reply other threads:[~2004-07-02 3:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-01 16:29 [BUG] hugetlb MAP_PRIVATE mapping vs /dev/zero Oleg Nesterov
2004-07-01 16:56 ` William Lee Irwin III
2004-07-01 21:55 ` Andrew Morton
2004-07-02 1:20 ` David Gibson
2004-07-02 2:44 ` William Lee Irwin III
2004-07-02 3:49 ` David Gibson [this message]
2004-07-02 4:12 ` David Gibson
2004-07-02 4:21 ` William Lee Irwin III
-- strict thread matches above, loose matches on Subject: below --
2004-07-02 12:12 Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040702034937.GE5937@zax \
--to=david@gibson.dropbear.id.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=torvalds@osdl.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.