From: William Lee Irwin III <wli@holomorphy.com>
To: David Gibson <david@gibson.dropbear.id.au>,
Oleg Nesterov <oleg@tv-sign.ru>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: [BUG] hugetlb MAP_PRIVATE mapping vs /dev/zero
Date: Thu, 1 Jul 2004 21:21:53 -0700 [thread overview]
Message-ID: <20040702042153.GJ21066@holomorphy.com> (raw)
In-Reply-To: <20040702041215.GG5937@zax>
On Fri, Jul 02, 2004 at 01:49:37PM +1000, David Gibson wrote:
>> Duh, sorry, misread the sense of the VM_SHARED test in the zeromap
>> code.
On Fri, Jul 02, 2004 at 02:12:15PM +1000, David Gibson wrote:
> On second thoughts, though, I think logically it should be fixed in
> both places. For now forcing VM_SHARED in the hugetlbfs code is
> sufficient, but if we ever allow (real) MAP_PRIVATE hugepage mappings
> (by implementing hugepage COW, for example), then the zeromap code
> will need fixing.
> Conceptually it's not so much the fact that the hugepage memory is
> shared which is tripping up zeromap as the fact that it isn't mapped
> in the normal way.
> Of course, one could argue that the whole zeromap idea is just too
> damn clever for its own good...
Better that there should be a zeromap_hugepage_range() than pollution
of random pseudodrivers.
-- wli
next prev parent reply other threads:[~2004-07-02 4:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-01 16:29 [BUG] hugetlb MAP_PRIVATE mapping vs /dev/zero Oleg Nesterov
2004-07-01 16:56 ` William Lee Irwin III
2004-07-01 21:55 ` Andrew Morton
2004-07-02 1:20 ` David Gibson
2004-07-02 2:44 ` William Lee Irwin III
2004-07-02 3:49 ` David Gibson
2004-07-02 4:12 ` David Gibson
2004-07-02 4:21 ` William Lee Irwin III [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-07-02 12:12 Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040702042153.GJ21066@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@osdl.org \
--cc=david@gibson.dropbear.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.