* [Kernel-janitors] Re: bluetooth: replace schedule_timeout() with
2004-07-20 18:45 [Kernel-janitors] Re: bluetooth: replace schedule_timeout() with Domen Puncer
@ 2004-07-20 18:52 ` Nishanth Aravamudan
2004-07-21 8:14 ` Marcel Holtmann
2004-07-21 16:06 ` Nishanth Aravamudan
2 siblings, 0 replies; 4+ messages in thread
From: Nishanth Aravamudan @ 2004-07-20 18:52 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1384 bytes --]
On Tue, Jul 20, 2004 at 08:45:10PM +0200, Domen Puncer wrote:
> On 20/07/04 18:18 +0000, Nishanth Aravamudan wrote:
> ...
> > --- linux-vanilla/drivers/bluetooth/bluecard_cs.c 2004-06-16 05:19:22.000000000 +0000
> > +++ linux-dev/drivers/bluetooth/bluecard_cs.c 2004-07-10 18:22:58.000000000 +0000
> > @@ -776,8 +776,7 @@ int bluecard_open(bluecard_info_t *info)
> > outb(0x80, iobase + 0x30);
> >
> > /* Wait some time */
> > - set_current_state(TASK_INTERRUPTIBLE);
> > - schedule_timeout(HZ / 100);
> > + msleep(100);
>
> This should be 10.
Thanks, here is the corrected patch:
--- linux-vanilla/drivers/bluetooth/bluecard_cs.c 2004-06-16 05:19:22.000000000 +0000
+++ linux-dev/drivers/bluetooth/bluecard_cs.c 2004-07-10 18:22:58.000000000 +0000
@@ -776,8 +776,7 @@ int bluecard_open(bluecard_info_t *info)
outb(0x80, iobase + 0x30);
/* Wait some time */
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(HZ / 100);
+ msleep(10);
/* Turn FPGA on */
outb(0x00, iobase + 0x30);
@@ -823,8 +822,7 @@ int bluecard_open(bluecard_info_t *info)
outb((0x0f << RTS_LEVEL_SHIFT_BITS) | 1, iobase + REG_RX_CONTROL);
/* Timeout before it is safe to send the first HCI packet */
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout((HZ * 5) / 4); // or set it to 3/2
+ msleep(1250);
/* Register HCI device */
if (hci_register_dev(hdev) < 0) {
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 4+ messages in thread* [Kernel-janitors] Re: bluetooth: replace schedule_timeout() with
2004-07-20 18:45 [Kernel-janitors] Re: bluetooth: replace schedule_timeout() with Domen Puncer
2004-07-20 18:52 ` Nishanth Aravamudan
@ 2004-07-21 8:14 ` Marcel Holtmann
2004-07-21 16:06 ` Nishanth Aravamudan
2 siblings, 0 replies; 4+ messages in thread
From: Marcel Holtmann @ 2004-07-21 8:14 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 855 bytes --]
Hi Nish,
> > > --- linux-vanilla/drivers/bluetooth/bluecard_cs.c 2004-06-16 05:19:22.000000000 +0000
> > > +++ linux-dev/drivers/bluetooth/bluecard_cs.c 2004-07-10 18:22:58.000000000 +0000
> > > @@ -776,8 +776,7 @@ int bluecard_open(bluecard_info_t *info)
> > > outb(0x80, iobase + 0x30);
> > >
> > > /* Wait some time */
> > > - set_current_state(TASK_INTERRUPTIBLE);
> > > - schedule_timeout(HZ / 100);
> > > + msleep(100);
> >
> > This should be 10.
>
> Thanks, here is the corrected patch:
the patches are still wrong, because of warnings like this:
CC [M] drivers/bluetooth/bluecard_cs.o
drivers/bluetooth/bluecard_cs.c: In function `bluecard_open':
drivers/bluetooth/bluecard_cs.c:779: warning: implicit declaration of function `msleep'
I fixed these warnings and now I have to test if the cards are still working.
Regards
Marcel
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Kernel-janitors] Re: bluetooth: replace schedule_timeout() with
2004-07-20 18:45 [Kernel-janitors] Re: bluetooth: replace schedule_timeout() with Domen Puncer
2004-07-20 18:52 ` Nishanth Aravamudan
2004-07-21 8:14 ` Marcel Holtmann
@ 2004-07-21 16:06 ` Nishanth Aravamudan
2 siblings, 0 replies; 4+ messages in thread
From: Nishanth Aravamudan @ 2004-07-21 16:06 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1154 bytes --]
On Wed, Jul 21, 2004 at 10:14:09AM +0200, Marcel Holtmann wrote:
> > > > --- linux-vanilla/drivers/bluetooth/bluecard_cs.c 2004-06-16 05:19:22.000000000 +0000
> > > > +++ linux-dev/drivers/bluetooth/bluecard_cs.c 2004-07-10 18:22:58.000000000 +0000
> > > > @@ -776,8 +776,7 @@ int bluecard_open(bluecard_info_t *info)
> > > > outb(0x80, iobase + 0x30);
> > > >
> > > > /* Wait some time */
> > > > - set_current_state(TASK_INTERRUPTIBLE);
> > > > - schedule_timeout(HZ / 100);
> > > > + msleep(100);
> > >
> > > This should be 10.
> >
> > Thanks, here is the corrected patch:
>
> the patches are still wrong, because of warnings like this:
>
> CC [M] drivers/bluetooth/bluecard_cs.o
> drivers/bluetooth/bluecard_cs.c: In function `bluecard_open':
> drivers/bluetooth/bluecard_cs.c:779: warning: implicit declaration of function `msleep'
>
> I fixed these warnings and now I have to test if the cards are still working.
Thank you for notifying me of this. I thought I had caught all of these
compile errors, but will now go back through and make sure before I
release any more patches. Sorry for the inconvenience, but I'm learning.
-Nish
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 4+ messages in thread