From: Ben Collins <bcollins@debian.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] [PATCH] ieee/sbp2: replace schedule_timeout()
Date: Thu, 22 Jul 2004 23:26:53 +0000 [thread overview]
Message-ID: <20040722232653.GC26547@phunnypharm.org> (raw)
In-Reply-To: <20040722223527.GV2165@us.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 833 bytes --]
On Thu, Jul 22, 2004 at 10:35:28PM +0000, Nishanth Aravamudan wrote:
> I would appreciate any comments from the janitors list. This is one (of
> many) cases where I made a decision about replacing
>
> set_current_state(TASK_INTERRUPTIBLE);
> schedule_timeout(some_time);
>
> with
>
> msleep(jiffies_to_msecs(some_time));
>
> msleep() is not exactly the same as the previous code, but I only did
> this replacement where I thought long delays were *desired*. If this is
> not the case here, then just disregard this patch.
Doesn't msleep() block? If so, that's not what we want at all. We want
other things to happen during that time (like maybe catch a bus reset).
--
Debian - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
WatchGuard - http://www.watchguard.com/
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2004-07-22 23:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-22 22:35 [Kernel-janitors] [PATCH] ieee/sbp2: replace schedule_timeout() with Nishanth Aravamudan
2004-07-22 23:26 ` Ben Collins [this message]
2004-07-23 1:04 ` [Kernel-janitors] [PATCH] ieee/sbp2: replace schedule_timeout() Matthew Wilcox
2004-07-23 1:53 ` Ben Collins
2004-07-23 4:33 ` Re: [Kernel-janitors] [PATCH] ieee/sbp2: replace Nish Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040722232653.GC26547@phunnypharm.org \
--to=bcollins@debian.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.