All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nish Aravamudan <nish.aravamudan@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: Re: [Kernel-janitors] [PATCH] ieee/sbp2: replace
Date: Fri, 23 Jul 2004 04:33:37 +0000	[thread overview]
Message-ID: <29495f1d04072221335cc55321@mail.gmail.com> (raw)
In-Reply-To: <20040722223527.GV2165@us.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]

On Thu, 22 Jul 2004 21:53:05 -0400, Ben Collins <bcollins@debian.org> wrote:
> On Fri, Jul 23, 2004 at 02:04:03AM +0100, Matthew Wilcox wrote:
> > On Thu, Jul 22, 2004 at 07:26:53PM -0400, Ben Collins wrote:
> > > Doesn't msleep() block? If so, that's not what we want at all. We want
> > > other things to happen during that time (like maybe catch a bus reset).
> >
> > No, msleep sleeps (as its name suggests).  The code that implements it is:
> 
> In that case, I've got a few places that could use msleep().

The one thing is, it depends on what you mean by "like maybe catch a
bus reset" (I think), because msleep will sleep through all signals,
i.e. it provides a guaranteed minimum delay. In the case of my patch,
I didn't see you checking for any signals afterwards (or any comments
indicating you were expecting some) so I figured it would be safe to
use msleep(). Also, I think it's clearer what's going on if the time
units for delays are msecs.

-Nish

PS. Would these other places be in drivers as well?

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

      parent reply	other threads:[~2004-07-23  4:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-22 22:35 [Kernel-janitors] [PATCH] ieee/sbp2: replace schedule_timeout() with Nishanth Aravamudan
2004-07-22 23:26 ` [Kernel-janitors] [PATCH] ieee/sbp2: replace schedule_timeout() Ben Collins
2004-07-23  1:04 ` Matthew Wilcox
2004-07-23  1:53 ` Ben Collins
2004-07-23  4:33 ` Nish Aravamudan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29495f1d04072221335cc55321@mail.gmail.com \
    --to=nish.aravamudan@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.