Re: [Kernel-janitors] [PATCH] ieee/sbp2: replace schedule_timeout()

From: Matthew Wilcox <willy@debian.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] [PATCH] ieee/sbp2: replace schedule_timeout()
Date: Fri, 23 Jul 2004 01:04:03 +0000	[thread overview]
Message-ID: <20040723010403.GC8730@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20040722223527.GV2165@us.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 954 bytes --]

On Thu, Jul 22, 2004 at 07:26:53PM -0400, Ben Collins wrote:
> Doesn't msleep() block? If so, that's not what we want at all. We want
> other things to happen during that time (like maybe catch a bus reset).

No, msleep sleeps (as its name suggests).  The code that implements it is:

void msleep(unsigned int msecs)
{
        unsigned long timeout = msecs_to_jiffies(msecs);

        while (timeout) {
                set_current_state(TASK_UNINTERRUPTIBLE);
                timeout = schedule_timeout(timeout);
        }
}

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors