All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, "Seth,
	Rohit" <rohit.seth@intel.com>
Subject: Re: Hugetlb demanding paging for -mm tree
Date: Thu, 05 Aug 2004 13:43:46 +0000	[thread overview]
Message-ID: <20040805134346.GD16763@wotan.suse.de> (raw)
In-Reply-To: <200408051329.i75DT3Y26431@unix-os.sc.intel.com>

> Patches are broken into two pieces.  But they should be applied together
> to have correct functionality for hugetlb demand paging.
> 
> 00.demandpaging.patch - core hugetlb demand paging
> 01.overcommit.patch   - hugetlbfs strict overcommit accounting.
> 
> Testing and comments are welcome.  Thanks.

Looks good so far to me. I can later add NUMA API on top of it.
Just one nit: please add a printk for the OOM case.
And: please don't send patches uuencoded, that makes it harder 
to review.

I didn't see the second part yet.

-Andi

WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@suse.de>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, "Seth,
	Rohit" <rohit.seth@intel.com>
Subject: Re: Hugetlb demanding paging for -mm tree
Date: Thu, 5 Aug 2004 15:43:46 +0200	[thread overview]
Message-ID: <20040805134346.GD16763@wotan.suse.de> (raw)
In-Reply-To: <200408051329.i75DT3Y26431@unix-os.sc.intel.com>

> Patches are broken into two pieces.  But they should be applied together
> to have correct functionality for hugetlb demand paging.
> 
> 00.demandpaging.patch - core hugetlb demand paging
> 01.overcommit.patch   - hugetlbfs strict overcommit accounting.
> 
> Testing and comments are welcome.  Thanks.

Looks good so far to me. I can later add NUMA API on top of it.
Just one nit: please add a printk for the OOM case.
And: please don't send patches uuencoded, that makes it harder 
to review.

I didn't see the second part yet.

-Andi

  parent reply	other threads:[~2004-08-05 13:43 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-05 13:29 Hugetlb demanding paging for -mm tree Chen, Kenneth W
2004-08-05 13:29 ` Chen, Kenneth W
2004-08-05 13:36 ` William Lee Irwin III
2004-08-05 13:36   ` William Lee Irwin III
2004-08-05 13:39 ` Chen, Kenneth W
2004-08-05 13:39   ` Chen, Kenneth W
2004-08-05 16:35   ` Hirokazu Takahashi
2004-08-05 16:35     ` Hirokazu Takahashi
2004-08-07  8:36   ` William Lee Irwin III
2004-08-07  8:36     ` William Lee Irwin III
2004-08-05 13:42 ` Chen, Kenneth W
2004-08-05 13:42   ` Chen, Kenneth W
2004-08-05 14:04   ` Andi Kleen
2004-08-05 14:04     ` Andi Kleen
2004-08-05 13:43 ` Andi Kleen [this message]
2004-08-05 13:43   ` Andi Kleen
2004-08-06 20:55 ` Chen, Kenneth W
2004-08-06 20:55   ` Chen, Kenneth W
2004-08-06 21:07   ` William Lee Irwin III
2004-08-06 21:07     ` William Lee Irwin III
2004-08-07  8:13     ` William Lee Irwin III
2004-08-07  8:13       ` William Lee Irwin III
2004-08-06 21:06 ` Chen, Kenneth W
2004-08-06 21:06   ` Chen, Kenneth W
2004-08-09 18:19 ` Chen, Kenneth W
2004-08-09 18:19   ` Chen, Kenneth W
2004-08-09 19:12   ` William Lee Irwin III
2004-08-09 19:12     ` William Lee Irwin III
2004-08-09 18:43 ` Seth, Rohit
2004-08-09 18:43   ` Seth, Rohit
2004-08-09 18:59   ` William Lee Irwin III
2004-08-09 18:59     ` William Lee Irwin III
2004-08-09 18:54 ` Chen, Kenneth W
2004-08-09 18:54   ` Chen, Kenneth W
2004-08-09 19:12   ` William Lee Irwin III
2004-08-09 19:12     ` William Lee Irwin III
2004-08-10  8:52 ` Seth, Rohit
2004-08-10  8:52   ` Seth, Rohit
2004-08-10  8:55   ` William Lee Irwin III
2004-08-10  8:55     ` William Lee Irwin III
2004-08-11  0:28 ` Seth, Rohit
2004-08-11  0:28   ` Seth, Rohit
2004-08-11  0:45   ` William Lee Irwin III
2004-08-11  0:45     ` William Lee Irwin III
2004-08-11  6:36 ` Seth, Rohit
2004-08-11  6:36   ` Seth, Rohit
2004-08-11  6:38   ` William Lee Irwin III
2004-08-11  6:38     ` William Lee Irwin III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040805134346.GD16763@wotan.suse.de \
    --to=ak@suse.de \
    --cc=kenneth.w.chen@intel.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rohit.seth@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.