All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: Andrew Morton <akpm@osdl.org>,
	AKIYAMA Nobuyuki <akiyama.nobuyuk@jp.fujitsu.com>
Cc: linux-kernel@vger.kernel.org
Subject: [patch] 2.6.8-rc4-mm1: NMI changes don't compile with SYSCTL=n
Date: Thu, 12 Aug 2004 00:14:23 +0200	[thread overview]
Message-ID: <20040811221423.GL26174@fs.tum.de> (raw)
In-Reply-To: <20040810002110.4fd8de07.akpm@osdl.org>

On Tue, Aug 10, 2004 at 12:21:10AM -0700, Andrew Morton wrote:
>...
> All 529 patches:
>...
> nmi-trigger-switch-support-for-debuggingupdated.patch
>   NMI trigger switch support for debugging(updated)
>...

This causes the following compile error with CONFIG_SYSCTL=n:

<--  snip  -->

...
  LD      .tmp_vmlinux1
arch/i386/kernel/built-in.o(.text+0x185de): In function 
`proc_unknown_nmi_panic':
: undefined reference to `unknown_nmi_panic'
arch/i386/kernel/built-in.o(.text+0x185ef): In function 
`proc_unknown_nmi_panic':
: undefined reference to `unknown_nmi_panic'
arch/i386/kernel/built-in.o(.text+0x18615): In function 
`proc_unknown_nmi_panic':
: undefined reference to `unknown_nmi_panic'
make: *** [.tmp_vmlinux1] Error 1

<--  snip  -->


 
The following patch fixes this issue:


Signed-off-by: Adrian Bunk <bunk@fs.tum.de>

--- linux-2.6.8-rc4-mm1/arch/i386/kernel/nmi.c.old	2004-08-12 00:07:57.000000000 +0200
+++ linux-2.6.8-rc4-mm1/arch/i386/kernel/nmi.c	2004-08-12 00:09:04.000000000 +0200
@@ -534,6 +534,8 @@
 	}
 }
 
+#ifdef CONFIG_SYSCTL
+
 static int unknown_nmi_panic_callback(struct pt_regs *regs, int cpu)
 {
 	unsigned char reason = get_nmi_reason();
@@ -573,6 +575,8 @@
 	return 0;
 }
 
+#endif
+
 EXPORT_SYMBOL(nmi_active);
 EXPORT_SYMBOL(nmi_watchdog);
 EXPORT_SYMBOL(reserve_lapic_nmi);


  parent reply	other threads:[~2004-08-11 22:14 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-10  7:21 2.6.8-rc4-mm1 Andrew Morton
2004-08-10 15:09 ` 2.6.8-rc4-mm1 doesn't boot Adrian Bunk
2004-08-10 15:59   ` Bjorn Helgaas
2004-08-10 17:32     ` Adrian Bunk
2004-08-10 22:46       ` Bjorn Helgaas
2004-08-10 23:56         ` Adrian Bunk
2004-08-11 20:33           ` Bjorn Helgaas
2004-08-11 23:23             ` Adrian Bunk
2004-08-11  9:56         ` Alan Cox
2004-08-10 16:37 ` 2.6.8-rc4-mm1 Jesse Barnes
2004-08-10 21:20   ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 22:39     ` 2.6.8-rc4-mm1 Robert Picco
2004-08-10 22:28       ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 22:30         ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 22:43           ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 22:45             ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 23:03               ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 23:38                 ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-11  2:01                 ` 2.6.8-rc4-mm1 Jesse Barnes
2004-08-10 23:15       ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 19:43 ` 2.6.8-rc4-mm1 (compile stats) John Cherry
2004-08-11  0:12 ` 2.6.8-rc4-mm1 Tom Vier
2004-08-11 11:35   ` [patch] 2.6.8-rc4-mm1: i2c-keywest.c compile error Adrian Bunk
2004-08-11 22:14 ` Adrian Bunk [this message]
2004-08-11 22:18 ` 2.6.8-rc4-mm1: legacy_va_layout compile error with SYSCTL=n Adrian Bunk
2004-08-11 22:33   ` William Lee Irwin III
2004-08-11 22:42     ` William Lee Irwin III
2004-08-11 22:46       ` William Lee Irwin III
2004-08-11 23:02     ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040811221423.GL26174@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=akiyama.nobuyuk@jp.fujitsu.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.