Re: 2.6.8-rc4-mm1: legacy_va_layout compile error with SYSCTL=n

[William Lee Irwin III <wli@holomorphy.com>]

On Tue, Aug 10, 2004 at 12:21:10AM -0700, Andrew Morton wrote:
>> sysctl-tunable-for-flexmmap.patch
>>   sysctl tunable for flexmmap

On Thu, Aug 12, 2004 at 12:18:25AM +0200, Adrian Bunk wrote:
> This patch breaks compilation with CONFIG_SYSCTL=n:
> <--  snip  -->
> ...
>   LD      .tmp_vmlinux1
> arch/i386/mm/built-in.o(.text+0x1cd6): In function `arch_pick_mmap_layout':
> : undefined reference to `sysctl_legacy_va_layout'
> make: *** [.tmp_vmlinux1] Error 1
> <--  snip  -->

Does this help?

Index: mm1-2.6.8-rc4/arch/i386/mm/mmap.c
===================================================================
--- mm1-2.6.8-rc4.orig/arch/i386/mm/mmap.c	2004-08-10 23:01:03.155047360 -0700
+++ mm1-2.6.8-rc4/arch/i386/mm/mmap.c	2004-08-11 15:22:17.606770256 -0700
@@ -47,6 +47,10 @@
 	return TASK_SIZE - (gap & PAGE_MASK);
 }
 
+#ifndef CONFIG_SYSCTL
+#define sysctl_legacy_va_layout	0
+#endif
+
 /*
  * This function, called very early during the creation of a new
  * process VM image, sets up which VM layout function to use: