From: Robert Picco <Robert.Picco@hp.com>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: Jesse Barnes <jbarnes@engr.sgi.com>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.8-rc4-mm1
Date: Tue, 10 Aug 2004 18:39:33 -0400 [thread overview]
Message-ID: <41194EA5.80706@hp.com> (raw)
In-Reply-To: <20040810212033.GY11200@holomorphy.com>
copy_thread expects a switch_stack below pt_regs on the stack. the
switch_stack would have the parent's bspstore value for computing how
much register backing store to copy into child. there isn't a
switch_stack and the resultant bspstore size computed is enormous
(depends on what there is on stack). i suspect printk has changed stack
and the code layout changed too.
diff -ruN -X /home/picco/losl/dontdiff linux-2.6.8-rc3-mm2-orig/arch/ia64/kernel/process.c linux-2.6.8-rc3-mm2/arch/ia64/kernel/process.c
--- linux-2.6.8-rc3-mm2-orig/arch/ia64/kernel/process.c 2004-08-10 17:24:51.000000000 -0400
+++ linux-2.6.8-rc3-mm2/arch/ia64/kernel/process.c 2004-08-10 17:33:51.000000000 -0400
@@ -352,7 +352,7 @@
* For SMP idle threads, fork_by_hand() calls do_fork with
* NULL regs.
*/
- if (!regs)
+ if (clone_flags & CLONE_IDLETASK)
return 0;
#endif
diff -ruN -X /home/picco/losl/dontdiff linux-2.6.8-rc3-mm2-orig/include/linux/sched.h linux-2.6.8-rc3-mm2/include/linux/sched.h
--- linux-2.6.8-rc3-mm2-orig/include/linux/sched.h 2004-08-10 17:25:07.000000000 -0400
+++ linux-2.6.8-rc3-mm2/include/linux/sched.h 2004-08-10 17:31:56.000000000 -0400
@@ -40,6 +40,7 @@
#define CLONE_FS 0x00000200 /* set if fs info shared between processes */
#define CLONE_FILES 0x00000400 /* set if open files shared between processes */
#define CLONE_SIGHAND 0x00000800 /* set if signal handlers and blocked signals shared */
+#define CLONE_IDLETASK 0x00001000 /* set if new pid should be 0 (kernel only)*/
#define CLONE_PTRACE 0x00002000 /* set if we want to let tracing continue on the child too */
#define CLONE_VFORK 0x00004000 /* set if the parent wants the child to wake it up on mm_release */
#define CLONE_PARENT 0x00008000 /* set if we want to have the same parent as the cloner */
diff -ruN -X /home/picco/losl/dontdiff linux-2.6.8-rc3-mm2-orig/kernel/fork.c linux-2.6.8-rc3-mm2/kernel/fork.c
--- linux-2.6.8-rc3-mm2-orig/kernel/fork.c 2004-08-10 17:25:10.000000000 -0400
+++ linux-2.6.8-rc3-mm2/kernel/fork.c 2004-08-10 17:32:56.000000000 -0400
@@ -1196,7 +1196,7 @@
struct pt_regs regs;
memset(®s, 0, sizeof(struct pt_regs));
- task = copy_process(CLONE_VM, 0, ®s, 0, NULL, NULL, 0);
+ task = copy_process(CLONE_VM|CLONE_IDLETASK, 0, ®s, 0, NULL, NULL, 0);
if (!task)
return ERR_PTR(-ENOMEM);
init_idle(task, cpu);
next prev parent reply other threads:[~2004-08-10 22:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-10 7:21 2.6.8-rc4-mm1 Andrew Morton
2004-08-10 15:09 ` 2.6.8-rc4-mm1 doesn't boot Adrian Bunk
2004-08-10 15:59 ` Bjorn Helgaas
2004-08-10 17:32 ` Adrian Bunk
2004-08-10 22:46 ` Bjorn Helgaas
2004-08-10 23:56 ` Adrian Bunk
2004-08-11 20:33 ` Bjorn Helgaas
2004-08-11 23:23 ` Adrian Bunk
2004-08-11 9:56 ` Alan Cox
2004-08-10 16:37 ` 2.6.8-rc4-mm1 Jesse Barnes
2004-08-10 21:20 ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 22:39 ` Robert Picco [this message]
2004-08-10 22:28 ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 22:30 ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 22:43 ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 22:45 ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 23:03 ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 23:38 ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-11 2:01 ` 2.6.8-rc4-mm1 Jesse Barnes
2004-08-10 23:15 ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 19:43 ` 2.6.8-rc4-mm1 (compile stats) John Cherry
2004-08-11 0:12 ` 2.6.8-rc4-mm1 Tom Vier
2004-08-11 11:35 ` [patch] 2.6.8-rc4-mm1: i2c-keywest.c compile error Adrian Bunk
2004-08-11 22:14 ` [patch] 2.6.8-rc4-mm1: NMI changes don't compile with SYSCTL=n Adrian Bunk
2004-08-11 22:18 ` 2.6.8-rc4-mm1: legacy_va_layout compile error " Adrian Bunk
2004-08-11 22:33 ` William Lee Irwin III
2004-08-11 22:42 ` William Lee Irwin III
2004-08-11 22:46 ` William Lee Irwin III
2004-08-11 23:02 ` Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2004-08-10 18:38 2.6.8-rc4-mm1 Diffie
2004-08-11 3:33 2.6.8-rc4-mm1 Diffie
2004-08-11 15:36 ` 2.6.8-rc4-mm1 Randy.Dunlap
2004-08-11 22:57 ` 2.6.8-rc4-mm1 Bjorn Helgaas
2004-08-12 5:48 ` 2.6.8-rc4-mm1 Paul Blazejowski
2004-08-12 18:49 2.6.8-rc4-mm1 Paul Blazejowski
2004-08-12 23:21 ` 2.6.8-rc4-mm1 Bjorn Helgaas
2004-08-13 8:15 ` 2.6.8-rc4-mm1 Paul Blazejowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41194EA5.80706@hp.com \
--to=robert.picco@hp.com \
--cc=akpm@osdl.org \
--cc=jbarnes@engr.sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.