All of lore.kernel.org
 help / color / mirror / Atom feed
From: maximilian attems <janitor@sternwelten.at>
To: kj <kernel-janitors@osdl.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [Kernel-janitors] [patch] remove-last-suser-call
Date: Sun, 15 Aug 2004 15:00:29 +0000	[thread overview]
Message-ID: <20040815150029.GJ1799@stro.at> (raw)

[-- Attachment #1: Type: text/plain, Size: 883 bytes --]



Attached patch removes the lone remaining suser() call,
suser() has long gone in summer 2002.
applies to 2.6.8.1-kjt1, compile tested

Signed-off-by: Maximilian Attems <janitor@sternwelten.at>



---

 linux-2.6.8-max/drivers/char/rocket.c |    4 ----
 1 files changed, 4 deletions(-)

diff -puN drivers/char/rocket.c~remove-last-suser-call drivers/char/rocket.c
--- linux-2.6.8/drivers/char/rocket.c~remove-last-suser-call	2004-08-15 16:54:13.000000000 +0200
+++ linux-2.6.8-max/drivers/char/rocket.c	2004-08-15 16:54:13.000000000 +0200
@@ -1283,11 +1283,7 @@ static int set_config(struct r_port *inf
 	if (copy_from_user(&new_serial, new_info, sizeof (new_serial)))
 		return -EFAULT;
 
-#ifdef CAP_SYS_ADMIN
 	if (!capable(CAP_SYS_ADMIN))
-#else
-	if (!suser())
-#endif
 	{
 		if ((new_serial.flags & ~ROCKET_USR_MASK) != (info->flags & ~ROCKET_USR_MASK))
 			return -EPERM;

_

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: maximilian attems <janitor@sternwelten.at>
To: kj <kernel-janitors@osdl.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [patch] remove-last-suser-call drivers/char/rocket.c
Date: Sun, 15 Aug 2004 17:00:29 +0200	[thread overview]
Message-ID: <20040815150029.GJ1799@stro.at> (raw)



Attached patch removes the lone remaining suser() call,
suser() has long gone in summer 2002.
applies to 2.6.8.1-kjt1, compile tested

Signed-off-by: Maximilian Attems <janitor@sternwelten.at>



---

 linux-2.6.8-max/drivers/char/rocket.c |    4 ----
 1 files changed, 4 deletions(-)

diff -puN drivers/char/rocket.c~remove-last-suser-call drivers/char/rocket.c
--- linux-2.6.8/drivers/char/rocket.c~remove-last-suser-call	2004-08-15 16:54:13.000000000 +0200
+++ linux-2.6.8-max/drivers/char/rocket.c	2004-08-15 16:54:13.000000000 +0200
@@ -1283,11 +1283,7 @@ static int set_config(struct r_port *inf
 	if (copy_from_user(&new_serial, new_info, sizeof (new_serial)))
 		return -EFAULT;
 
-#ifdef CAP_SYS_ADMIN
 	if (!capable(CAP_SYS_ADMIN))
-#else
-	if (!suser())
-#endif
 	{
 		if ((new_serial.flags & ~ROCKET_USR_MASK) != (info->flags & ~ROCKET_USR_MASK))
 			return -EPERM;

_

             reply	other threads:[~2004-08-15 15:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-15 15:00 maximilian attems [this message]
2004-08-15 15:00 ` [patch] remove-last-suser-call drivers/char/rocket.c maximilian attems

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040815150029.GJ1799@stro.at \
    --to=janitor@sternwelten.at \
    --cc=kernel-janitors@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.