[Kernel-janitors] [patch] remove-last-suser-call

[Kernel-janitors] [patch] remove-last-suser-call

[maximilian attems]

[-- Attachment #1: Type: text/plain, Size: 883 bytes --]



Attached patch removes the lone remaining suser() call,
suser() has long gone in summer 2002.
applies to 2.6.8.1-kjt1, compile tested

Signed-off-by: Maximilian Attems <janitor@sternwelten.at>



---

 linux-2.6.8-max/drivers/char/rocket.c |    4 ----
 1 files changed, 4 deletions(-)

diff -puN drivers/char/rocket.c~remove-last-suser-call drivers/char/rocket.c
--- linux-2.6.8/drivers/char/rocket.c~remove-last-suser-call	2004-08-15 16:54:13.000000000 +0200
+++ linux-2.6.8-max/drivers/char/rocket.c	2004-08-15 16:54:13.000000000 +0200
@@ -1283,11 +1283,7 @@ static int set_config(struct r_port *inf
 	if (copy_from_user(&new_serial, new_info, sizeof (new_serial)))
 		return -EFAULT;
 
-#ifdef CAP_SYS_ADMIN
 	if (!capable(CAP_SYS_ADMIN))
-#else
-	if (!suser())
-#endif
 	{
 		if ((new_serial.flags & ~ROCKET_USR_MASK) != (info->flags & ~ROCKET_USR_MASK))
 			return -EPERM;

_

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[patch] remove-last-suser-call drivers/char/rocket.c

[maximilian attems]

Attached patch removes the lone remaining suser() call,
suser() has long gone in summer 2002.
applies to 2.6.8.1-kjt1, compile tested

Signed-off-by: Maximilian Attems <janitor@sternwelten.at>



---

 linux-2.6.8-max/drivers/char/rocket.c |    4 ----
 1 files changed, 4 deletions(-)

diff -puN drivers/char/rocket.c~remove-last-suser-call drivers/char/rocket.c
--- linux-2.6.8/drivers/char/rocket.c~remove-last-suser-call	2004-08-15 16:54:13.000000000 +0200
+++ linux-2.6.8-max/drivers/char/rocket.c	2004-08-15 16:54:13.000000000 +0200
@@ -1283,11 +1283,7 @@ static int set_config(struct r_port *inf
 	if (copy_from_user(&new_serial, new_info, sizeof (new_serial)))
 		return -EFAULT;
 
-#ifdef CAP_SYS_ADMIN
 	if (!capable(CAP_SYS_ADMIN))
-#else
-	if (!suser())
-#endif
 	{
 		if ((new_serial.flags & ~ROCKET_USR_MASK) != (info->flags & ~ROCKET_USR_MASK))
 			return -EPERM;

_