All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Grundler <iod00d@hp.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	linux-ia64@vger.kernel.org
Subject: Re: [RFC&PATCH 1/2] PCI Error Recovery (readX_check)
Date: Wed, 25 Aug 2004 15:52:13 +0000	[thread overview]
Message-ID: <20040825155213.GB19447@cup.hp.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0408250015420.17766@ppc970.osdl.org>

On Wed, Aug 25, 2004 at 12:20:45AM -0700, Linus Torvalds wrote:
> Because if you don't lock the bridge (or whatever the entity is that keeps 
> track of errors), the whole exercise is kind of pointless. If two drivers 
> try to do error checking at the same time, and will potentially clear the 
> errors of each other, causing the errors to get lost, the whole recovery 
> infrastructure is clearly worthless.

Do we only need to determine there was an error in the IO hierarchy
or do we also need to know which device/driver caused the error?

If the latter I agree with linus. If the former, then the error recovery
can support asyncronous errors (like the bad DMA address case) and tell
all affected (thanks willy) drivers.

grant

WARNING: multiple messages have this Message-ID (diff)
From: Grant Grundler <iod00d@hp.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	linux-ia64@vger.kernel.org
Subject: Re: [RFC&PATCH 1/2] PCI Error Recovery (readX_check)
Date: Wed, 25 Aug 2004 08:52:13 -0700	[thread overview]
Message-ID: <20040825155213.GB19447@cup.hp.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0408250015420.17766@ppc970.osdl.org>

On Wed, Aug 25, 2004 at 12:20:45AM -0700, Linus Torvalds wrote:
> Because if you don't lock the bridge (or whatever the entity is that keeps 
> track of errors), the whole exercise is kind of pointless. If two drivers 
> try to do error checking at the same time, and will potentially clear the 
> errors of each other, causing the errors to get lost, the whole recovery 
> infrastructure is clearly worthless.

Do we only need to determine there was an error in the IO hierarchy
or do we also need to know which device/driver caused the error?

If the latter I agree with linus. If the former, then the error recovery
can support asyncronous errors (like the bad DMA address case) and tell
all affected (thanks willy) drivers.

grant

  reply	other threads:[~2004-08-25 15:52 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-24  5:24 [RFC&PATCH 1/2] PCI Error Recovery (readX_check) Hidetoshi Seto
2004-08-24  5:24 ` Hidetoshi Seto
2004-08-24  5:41 ` Linus Torvalds
2004-08-24  5:41   ` Linus Torvalds
2004-08-24  8:06   ` Hidetoshi Seto
2004-08-24  8:06     ` Hidetoshi Seto
2004-08-25  7:01   ` Benjamin Herrenschmidt
2004-08-25  7:01     ` Benjamin Herrenschmidt
2004-08-25  7:20     ` Linus Torvalds
2004-08-25  7:20       ` Linus Torvalds
2004-08-25 15:52       ` Grant Grundler [this message]
2004-08-25 15:52         ` Grant Grundler
2004-08-25 17:25         ` Linus Torvalds
2004-08-25 17:25           ` Linus Torvalds
2004-08-25 23:23       ` Benjamin Herrenschmidt
2004-08-25 23:23         ` Benjamin Herrenschmidt
2004-08-25 23:35         ` Linus Torvalds
2004-08-25 23:35           ` Linus Torvalds
2004-08-25 15:42     ` Grant Grundler
2004-08-25 15:42       ` Grant Grundler
2004-08-28  1:23 ` Hidetoshi Seto
2004-08-28  1:23   ` Hidetoshi Seto
2004-09-17 12:00   ` Hidetoshi Seto
2004-09-17 12:00     ` Hidetoshi Seto
2004-09-17 12:06   ` Hidetoshi Seto
2004-09-17 12:06     ` Hidetoshi Seto
2004-09-18  4:36     ` Grant Grundler
2004-09-18  4:36       ` Grant Grundler
2004-09-21  8:32       ` Hidetoshi Seto
2004-09-21  8:32         ` Hidetoshi Seto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040825155213.GB19447@cup.hp.com \
    --to=iod00d@hp.com \
    --cc=benh@kernel.crashing.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.