All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herve Eychenne <rv@wallfire.org>
To: Patrick McHardy <kaber@trash.net>
Cc: Netfilter Development <netfilter-devel@lists.netfilter.org>
Subject: Re: [PATCH] multiple changes/fixes
Date: Fri, 27 Aug 2004 18:28:09 +0200	[thread overview]
Message-ID: <20040827162808.GA29915@eychenne.org> (raw)
In-Reply-To: <412F5A3C.1000704@trash.net>

On Fri, Aug 27, 2004 at 05:58:52PM +0200, Patrick McHardy wrote:

> Herve Eychenne wrote:

> >I tried my best not to forget anything, especially regarding global
> >coherence, synchronisation between IPv4 and IPv6 parts, or between
> >options, help messages and man pages.
> >Yet, this patch touches quite simple but multiple things, so one never
> >knows... Further reviews/testing welcome!

> Would it be possible that you split the patch into logical changes
> so it's easier to review ?

I was afraid someone would say that. Does someone know a good tool to
split patches? I think of a X11 that would enable to drag and drop
diff file portions to several new areas/patches, with an option that
would automatically create one containing only whitespace changes.

Otherwise I guess I may not have the courage to do it. :-(

 Herve

-- 
 _
(°=  Hervé Eychenne
//)
v_/_ WallFire project:  http://www.wallfire.org/

  reply	other threads:[~2004-08-27 16:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-27 13:37 [PATCH] multiple changes/fixes Herve Eychenne
2004-08-27 15:58 ` Patrick McHardy
2004-08-27 16:28   ` Herve Eychenne [this message]
2004-08-27 20:08     ` Patrick McHardy
2004-08-28  0:01       ` Herve Eychenne
2004-08-28  0:32         ` Henrik Nordstrom
2004-08-28  0:40           ` Herve Eychenne
2004-08-28  0:50             ` Henrik Nordstrom
2004-08-28  1:03               ` Herve Eychenne
2004-08-28  2:13   ` Herve Eychenne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040827162808.GA29915@eychenne.org \
    --to=rv@wallfire.org \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.