All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herve Eychenne <rv@wallfire.org>
To: Henrik Nordstrom <hno@marasystems.com>
Cc: Netfilter Development <netfilter-devel@lists.netfilter.org>,
	Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH] multiple changes/fixes
Date: Sat, 28 Aug 2004 03:03:06 +0200	[thread overview]
Message-ID: <20040828010306.GD2416@eychenne.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0408280248010.10624@filer.marasystems.com>

On Sat, Aug 28, 2004 at 02:50:17AM +0200, Henrik Nordstrom wrote:

> On Sat, 28 Aug 2004, Herve Eychenne wrote:

> >Yes... run indent on the current tree, run indent on the patched tree,
> >and run diff on the two "indented" trees. But... too late: I took one
> >hour to remove the fluff from my patch (sigh).

> Found yet another useful tool for splitting patches with less 
> dependencies: tkdiff

I use it all the time, but I don't really see how it can help to
split patches affecting multiple files efficiently (you're talking
about the merge functionnality, aren't you?), as it works with two
versions of a file at a time, and not a diff file nor 2 trees...

> >I'll post 2 new patches tonight (if my head does not fall heavily on my
> >keyboard til then): one containing the information, the other containing
> >syntaxical or cosmetic changes, and typo fixes.

> Great!

Maybe I've talked a little bit too fast, as the patch modified by hand
doesn't apply anymore, and I cannot get it to apply even when playing
with rediff and recountdiff (from the patchutils).

> And thanks for encouraging me to look for tools doing this job easier. Was 
> more things around than I expected to find.

You're welcome... ;-)

 Herve

-- 
 _
(°=  Hervé Eychenne
//)
v_/_ WallFire project:  http://www.wallfire.org/

  reply	other threads:[~2004-08-28  1:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-27 13:37 [PATCH] multiple changes/fixes Herve Eychenne
2004-08-27 15:58 ` Patrick McHardy
2004-08-27 16:28   ` Herve Eychenne
2004-08-27 20:08     ` Patrick McHardy
2004-08-28  0:01       ` Herve Eychenne
2004-08-28  0:32         ` Henrik Nordstrom
2004-08-28  0:40           ` Herve Eychenne
2004-08-28  0:50             ` Henrik Nordstrom
2004-08-28  1:03               ` Herve Eychenne [this message]
2004-08-28  2:13   ` Herve Eychenne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040828010306.GD2416@eychenne.org \
    --to=rv@wallfire.org \
    --cc=hno@marasystems.com \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.