All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herve Eychenne <rv@wallfire.org>
To: Henrik Nordstrom <hno@marasystems.com>
Cc: Netfilter Development <netfilter-devel@lists.netfilter.org>,
	Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH] multiple changes/fixes
Date: Sat, 28 Aug 2004 02:40:39 +0200	[thread overview]
Message-ID: <20040828004039.GC2416@eychenne.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0408280202470.10193@filer.marasystems.com>

On Sat, Aug 28, 2004 at 02:32:19AM +0200, Henrik Nordstrom wrote:

> There is several tools doing a very good job of cleaning up indentation 
> and formatting. My favorite for C code is indent. There is no need of 
> doing this by hand.

> On the other hand the same tool can be used to identify the real changes 
> "after the fact" even if the original code was a mess, simply by diffing 
> the modified version with an original version formatted by the same tool.

Yes... run indent on the current tree, run indent on the patched tree,
and run diff on the two "indented" trees. But... too late: I took one
hour to remove the fluff from my patch (sigh).
I'll post 2 new patches tonight (if my head does not fall heavily on my
keyboard til then): one containing the information, the other containing
syntaxical or cosmetic changes, and typo fixes.

 Herve

-- 
 _
(°=  Hervé Eychenne
//)
v_/_ WallFire project:  http://www.wallfire.org/

  reply	other threads:[~2004-08-28  0:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-27 13:37 [PATCH] multiple changes/fixes Herve Eychenne
2004-08-27 15:58 ` Patrick McHardy
2004-08-27 16:28   ` Herve Eychenne
2004-08-27 20:08     ` Patrick McHardy
2004-08-28  0:01       ` Herve Eychenne
2004-08-28  0:32         ` Henrik Nordstrom
2004-08-28  0:40           ` Herve Eychenne [this message]
2004-08-28  0:50             ` Henrik Nordstrom
2004-08-28  1:03               ` Herve Eychenne
2004-08-28  2:13   ` Herve Eychenne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040828004039.GC2416@eychenne.org \
    --to=rv@wallfire.org \
    --cc=hno@marasystems.com \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.