* [Kernel-janitors] Re: isdn/icn: change units of ICN_BOOT_TIMEOUT1
@ 2004-09-18 21:13 Domen Puncer
2004-09-20 16:04 ` Nishanth Aravamudan
0 siblings, 1 reply; 2+ messages in thread
From: Domen Puncer @ 2004-09-18 21:13 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1558 bytes --]
On 17/09/04 10:52 -0700, Nishanth Aravamudan wrote:
> Any comments would be appreciated. This is a re-push of a patch
> submitted a few months ago which has not been merged as of
> 2.6.9-rc1-mm5 / 2.6.9-rc2.
>
> Description: Change units of ICN_BOOT_TIMEOUT1 to msecs instead of
> jiffies for msleep_interruptible() in icn.c. Also, remove unused
> constant ICN_CHANLOCK_DELAY.
>
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
>
> --- 2.6.9-rc2-vanilla/drivers/isdn/icn/icn.h 2004-09-13 17:16:04.000000000 -0700
> +++ 2.6.9-rc2/drivers/isdn/icn/icn.h 2004-09-17 10:43:35.000000000 -0700
> @@ -70,8 +70,7 @@ typedef struct icn_cdef {
> #define ICN_FLAGS_RUNNING 4 /* Cards driver activated */
> #define ICN_FLAGS_RBTIMER 8 /* cyclic scheduling of B-Channel-poll */
>
> -#define ICN_BOOT_TIMEOUT1 (HZ) /* Delay for Boot-download (jiffies) */
> -#define ICN_CHANLOCK_DELAY (HZ/10) /* Delay for Channel-mapping (jiffies) */
> +#define ICN_BOOT_TIMEOUT1 (1000) /* Delay for Boot-download (jiffies) */
Change comment to msecs too.
And some nitpicking: :-)
Numbers in defines don't have to be in ()'s.
Also, code seem to have formated "*/", your patch breaks it.
> #define ICN_TIMER_BCREAD (HZ/100) /* B-Channel poll-cycle */
> #define ICN_TIMER_DCREAD (HZ/2) /* D-Channel poll-cycle */
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> http://lists.osdl.org/mailman/listinfo/kernel-janitors
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 2+ messages in thread* [Kernel-janitors] Re: isdn/icn: change units of ICN_BOOT_TIMEOUT1
2004-09-18 21:13 [Kernel-janitors] Re: isdn/icn: change units of ICN_BOOT_TIMEOUT1 Domen Puncer
@ 2004-09-20 16:04 ` Nishanth Aravamudan
0 siblings, 0 replies; 2+ messages in thread
From: Nishanth Aravamudan @ 2004-09-20 16:04 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 2149 bytes --]
On Sat, Sep 18, 2004 at 11:13:25PM +0200, Domen Puncer wrote:
> On 17/09/04 10:52 -0700, Nishanth Aravamudan wrote:
> > Any comments would be appreciated. This is a re-push of a patch
> > submitted a few months ago which has not been merged as of
> > 2.6.9-rc1-mm5 / 2.6.9-rc2.
> >
> > Description: Change units of ICN_BOOT_TIMEOUT1 to msecs instead of
> > jiffies for msleep_interruptible() in icn.c. Also, remove unused
> > constant ICN_CHANLOCK_DELAY.
> >
> > Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> >
> > --- 2.6.9-rc2-vanilla/drivers/isdn/icn/icn.h 2004-09-13 17:16:04.000000000 -0700
> > +++ 2.6.9-rc2/drivers/isdn/icn/icn.h 2004-09-17 10:43:35.000000000 -0700
> > @@ -70,8 +70,7 @@ typedef struct icn_cdef {
> > #define ICN_FLAGS_RUNNING 4 /* Cards driver activated */
> > #define ICN_FLAGS_RBTIMER 8 /* cyclic scheduling of B-Channel-poll */
> >
> > -#define ICN_BOOT_TIMEOUT1 (HZ) /* Delay for Boot-download (jiffies) */
> > -#define ICN_CHANLOCK_DELAY (HZ/10) /* Delay for Channel-mapping (jiffies) */
> > +#define ICN_BOOT_TIMEOUT1 (1000) /* Delay for Boot-download (jiffies) */
>
> Change comment to msecs too.
>
> And some nitpicking: :-)
> Numbers in defines don't have to be in ()'s.
> Also, code seem to have formated "*/", your patch breaks it.
Please find the corrected patch below. Thanks, Domen!
--- 2.6.9-rc2-vanilla/drivers/isdn/icn/icn.h 2004-09-13 17:16:04.000000000 -0700
+++ 2.6.9-rc2/drivers/isdn/icn/icn.h 2004-09-20 09:00:16.000000000 -0700
@@ -70,8 +70,7 @@ typedef struct icn_cdef {
#define ICN_FLAGS_RUNNING 4 /* Cards driver activated */
#define ICN_FLAGS_RBTIMER 8 /* cyclic scheduling of B-Channel-poll */
-#define ICN_BOOT_TIMEOUT1 (HZ) /* Delay for Boot-download (jiffies) */
-#define ICN_CHANLOCK_DELAY (HZ/10) /* Delay for Channel-mapping (jiffies) */
+#define ICN_BOOT_TIMEOUT1 1000 /* Delay for Boot-download (msecs) */
#define ICN_TIMER_BCREAD (HZ/100) /* B-Channel poll-cycle */
#define ICN_TIMER_DCREAD (HZ/2) /* D-Channel poll-cycle */
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-09-20 16:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-18 21:13 [Kernel-janitors] Re: isdn/icn: change units of ICN_BOOT_TIMEOUT1 Domen Puncer
2004-09-20 16:04 ` Nishanth Aravamudan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.