Re: [Kernel-janitors] [PATCH] net/cs89x0: replace schedule_timeout()

Re: [Kernel-janitors] [PATCH] net/cs89x0: replace schedule_timeout()

[maximilian attems]

[-- Attachment #1: Type: text/plain, Size: 1335 bytes --]

On Mon, 26 Jul 2004, Nishanth Aravamudan wrote:

> I would appreciate any comments from the janitors list. This is one (of
> many) cases where I made a decision about replacing
> 
> set_current_state(TASK_INTERRUPTIBLE);
> schedule_timeout(some_time);
> 
> with
> 
> msleep(jiffies_to_msecs(some_time));
> 
> msleep() is not exactly the same as the previous code, but I only did
> this replacement where I thought long delays were *desired*. If this is
> not the case here, then just disregard this patch. 
> 
> Thanks,
> Nish
> 
> 
> 
> Applys-to: 2.6.7
> 
> Description: Replace schedule_timeout() with msleep() to guarantee the
> task delays for the desired time.
> 
> 
> --- linux-vanilla/drivers/net/cs89x0.c	2004-06-16 05:19:52.000000000 +0000
> +++ linux-dev/drivers/net/cs89x0.c	2004-07-12 18:59:24.000000000 +0000
> @@ -889,8 +889,7 @@ void  __init reset_chip(struct net_devic
>  	writereg(dev, PP_SelfCTL, readreg(dev, PP_SelfCTL) | POWER_ON_RESET);
>  
>  	/* wait 30 ms */
> -	current->state = TASK_INTERRUPTIBLE;
> -	schedule_timeout(30*HZ/1000);
> +	msleep(30);
>  
>  	if (lp->chip_type != CS8900) {
>  		/* Hardware problem requires PNP registers to be reconfigured after a reset */

this one doesn't compile:
drivers/net/cs89x0.c:912: warning: implicit declaration of function `msleep'

fixed for next kjt.
a++ maks



[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] [PATCH] net/cs89x0: replace schedule_timeout()

[Nishanth Aravamudan]

[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]

I would appreciate any comments from the janitors list. This is one (of
many) cases where I made a decision about replacing

set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(some_time);

with

msleep(jiffies_to_msecs(some_time));

msleep() is not exactly the same as the previous code, but I only did
this replacement where I thought long delays were *desired*. If this is
not the case here, then just disregard this patch. 

Thanks,
Nish



Applys-to: 2.6.7

Description: Replace schedule_timeout() with msleep() to guarantee the
task delays for the desired time.


--- linux-vanilla/drivers/net/cs89x0.c	2004-06-16 05:19:52.000000000 +0000
+++ linux-dev/drivers/net/cs89x0.c	2004-07-12 18:59:24.000000000 +0000
@@ -889,8 +889,7 @@ void  __init reset_chip(struct net_devic
 	writereg(dev, PP_SelfCTL, readreg(dev, PP_SelfCTL) | POWER_ON_RESET);
 
 	/* wait 30 ms */
-	current->state = TASK_INTERRUPTIBLE;
-	schedule_timeout(30*HZ/1000);
+	msleep(30);
 
 	if (lp->chip_type != CS8900) {
 		/* Hardware problem requires PNP registers to be reconfigured after a reset */

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors