All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] [PATCH 2.6.9-rc2 2/9] usb/auerswald: reorder
Date: Mon, 27 Sep 2004 21:46:38 +0000	[thread overview]
Message-ID: <20040927214638.GK1617@us.ibm.com> (raw)
In-Reply-To: <20040927214339.GI1617@us.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 699 bytes --]

Wrong subject line! Please use this version.

-Nish


Description: Reorder set_current_state() and schedule_timeout() so that
schedule_timeout() will delay as expected every iteration of the
while-loop. Without the addition, schedule_timeout() will return
immediately in the first iteration.

--- 2.6.9-rc2-vanilla/drivers/usb/misc/auerswald.c	2004-09-13 17:15:54.000000000 -0700
+++ 2.6.9-rc2/drivers/usb/misc/auerswald.c	2004-09-27 14:42:24.000000000 -0700
@@ -626,8 +626,8 @@ static int auerchain_start_wait_urb (pau
 
 	while (timeout && !chs.done)
 	{
-		timeout = schedule_timeout (timeout);
 		set_current_state(TASK_UNINTERRUPTIBLE);
+		timeout = schedule_timeout (timeout);
 		rmb();
 	}
 

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

      reply	other threads:[~2004-09-27 21:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-27 21:43 [Kernel-janitors] [PATCH 2.6.9-rc2 2/9] usb/auerswald: add Nishanth Aravamudan
2004-09-27 21:46 ` Nishanth Aravamudan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040927214638.GK1617@us.ibm.com \
    --to=nacc@us.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.