* [Kernel-janitors] [PATCH 2.6.9-rc2 2/9] usb/auerswald: add
@ 2004-09-27 21:43 Nishanth Aravamudan
2004-09-27 21:46 ` [Kernel-janitors] [PATCH 2.6.9-rc2 2/9] usb/auerswald: reorder Nishanth Aravamudan
0 siblings, 1 reply; 2+ messages in thread
From: Nishanth Aravamudan @ 2004-09-27 21:43 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 732 bytes --]
Any comments would be appreciated. One patch removed from USB set, so
total is now 9.
Description: Reorder set_current_state() and schedule_timeout() so that
schedule_timeout() will delay as expected every iteration of the
while-loop. Without the addition, schedule_timeout() will return
immediately in the first iteration.
--- 2.6.9-rc2-vanilla/drivers/usb/misc/auerswald.c 2004-09-13 17:15:54.000000000 -0700
+++ 2.6.9-rc2/drivers/usb/misc/auerswald.c 2004-09-27 14:42:24.000000000 -0700
@@ -626,8 +626,8 @@ static int auerchain_start_wait_urb (pau
while (timeout && !chs.done)
{
- timeout = schedule_timeout (timeout);
set_current_state(TASK_UNINTERRUPTIBLE);
+ timeout = schedule_timeout (timeout);
rmb();
}
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Kernel-janitors] [PATCH 2.6.9-rc2 2/9] usb/auerswald: reorder
2004-09-27 21:43 [Kernel-janitors] [PATCH 2.6.9-rc2 2/9] usb/auerswald: add Nishanth Aravamudan
@ 2004-09-27 21:46 ` Nishanth Aravamudan
0 siblings, 0 replies; 2+ messages in thread
From: Nishanth Aravamudan @ 2004-09-27 21:46 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 699 bytes --]
Wrong subject line! Please use this version.
-Nish
Description: Reorder set_current_state() and schedule_timeout() so that
schedule_timeout() will delay as expected every iteration of the
while-loop. Without the addition, schedule_timeout() will return
immediately in the first iteration.
--- 2.6.9-rc2-vanilla/drivers/usb/misc/auerswald.c 2004-09-13 17:15:54.000000000 -0700
+++ 2.6.9-rc2/drivers/usb/misc/auerswald.c 2004-09-27 14:42:24.000000000 -0700
@@ -626,8 +626,8 @@ static int auerchain_start_wait_urb (pau
while (timeout && !chs.done)
{
- timeout = schedule_timeout (timeout);
set_current_state(TASK_UNINTERRUPTIBLE);
+ timeout = schedule_timeout (timeout);
rmb();
}
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-09-27 21:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-27 21:43 [Kernel-janitors] [PATCH 2.6.9-rc2 2/9] usb/auerswald: add Nishanth Aravamudan
2004-09-27 21:46 ` [Kernel-janitors] [PATCH 2.6.9-rc2 2/9] usb/auerswald: reorder Nishanth Aravamudan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.