* [Kernel-janitors] [PATCH 2.6.9-rc2 1/4] mtd/amd_flash: replace
2004-09-20 22:12 [Kernel-janitors] [PATCH 2.6.9-rc2 1/4] message/device: replace Nishanth Aravamudan
@ 2004-09-20 23:57 ` Nishanth Aravamudan
2004-09-24 23:18 ` [Kernel-janitors] [PATCH 2.6.9-rc2 1/4] pci hotplug/cpqphp_ctrl: Nishanth Aravamudan
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Nishanth Aravamudan @ 2004-09-20 23:57 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 579 bytes --]
Any comments would be appreciated.
Description: Use msleep() instead of schedule_timeout()
to guarantee the task delays as expected.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.9-rc2-vanilla/drivers/mtd/chips/amd_flash.c 2004-09-13 17:16:04.000000000 -0700
+++ 2.6.9-rc2/drivers/mtd/chips/amd_flash.c 2004-09-15 09:30:31.000000000 -0700
@@ -1122,7 +1122,7 @@ retry:
timeo = jiffies + (HZ * 20);
spin_unlock_bh(chip->mutex);
- schedule_timeout(HZ);
+ msleep(1000);
spin_lock_bh(chip->mutex);
while (flash_is_busy(map, adr, private->interleave)) {
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 6+ messages in thread* [Kernel-janitors] [PATCH 2.6.9-rc2 1/4] pci hotplug/cpqphp_ctrl:
2004-09-20 22:12 [Kernel-janitors] [PATCH 2.6.9-rc2 1/4] message/device: replace Nishanth Aravamudan
2004-09-20 23:57 ` [Kernel-janitors] [PATCH 2.6.9-rc2 1/4] mtd/amd_flash: replace Nishanth Aravamudan
@ 2004-09-24 23:18 ` Nishanth Aravamudan
2004-09-27 17:24 ` [Kernel-janitors] [PATCH 2.6.9-rc2 1/4] sbus/aurora: replace Nishanth Aravamudan
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Nishanth Aravamudan @ 2004-09-24 23:18 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 733 bytes --]
Any comments would be appreciated.
Description: Use msleep_interruptible() instead of
schedule_timeout() to guarantee the task delays as expected.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.9-rc1-mm4-vanilla/drivers/pci/hotplug/cpqphp_ctrl.c 2004-09-09 23:05:35.000000000 -0700
+++ 2.6.9-rc1-mm4/drivers/pci/hotplug/cpqphp_ctrl.c 2004-09-10 15:33:04.000000000 -0700
@@ -69,10 +69,8 @@ static void long_delay(int delay)
init_waitqueue_head(&delay_wait);
add_wait_queue(&delay_wait, &wait);
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(delay);
+ msleep_interruptible(jiffies_to_msecs(delay));
remove_wait_queue(&delay_wait, &wait);
- set_current_state(TASK_RUNNING);
up(&delay_sem);
}
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 6+ messages in thread* [Kernel-janitors] [PATCH 2.6.9-rc2 1/4] sbus/aurora: replace
2004-09-20 22:12 [Kernel-janitors] [PATCH 2.6.9-rc2 1/4] message/device: replace Nishanth Aravamudan
2004-09-20 23:57 ` [Kernel-janitors] [PATCH 2.6.9-rc2 1/4] mtd/amd_flash: replace Nishanth Aravamudan
2004-09-24 23:18 ` [Kernel-janitors] [PATCH 2.6.9-rc2 1/4] pci hotplug/cpqphp_ctrl: Nishanth Aravamudan
@ 2004-09-27 17:24 ` Nishanth Aravamudan
2004-09-27 23:06 ` [Kernel-janitors] [PATCH 2.6.9-rc2 1/4] video/pxafb: replace Nishanth Aravamudan
2004-09-27 23:17 ` [Kernel-janitors] [PATCH 2.6.9-rc2 1/4] w1/dscore: replace Nishanth Aravamudan
4 siblings, 0 replies; 6+ messages in thread
From: Nishanth Aravamudan @ 2004-09-27 17:24 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]
Any comments would be appreciated.
Description: Use msleep_interruptible() instead of
schedule_timeout() to guarantee the task delays as expected.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.9-rc1-mm4-vanilla/drivers/sbus/char/aurora.c 2004-09-09 23:05:59.000000000 -0700
+++ 2.6.9-rc1-mm4/drivers/sbus/char/aurora.c 2004-09-10 15:37:43.000000000 -0700
@@ -1519,8 +1519,7 @@ static void aurora_close(struct tty_stru
*/
timeout = jiffies+HZ;
while(port->SRER & SRER_TXEMPTY) {
- current->state = TASK_INTERRUPTIBLE;
- schedule_timeout(port->timeout);
+ msleep_interruptible(jiffies_to_msecs(port->timeout));
if (time_after(jiffies, timeout))
break;
}
@@ -1538,8 +1537,7 @@ static void aurora_close(struct tty_stru
port->tty = 0;
if (port->blocked_open) {
if (port->close_delay) {
- current->state = TASK_INTERRUPTIBLE;
- schedule_timeout(port->close_delay);
+ msleep_interruptible(port->close_delay);
}
wake_up_interruptible(&port->open_wait);
}
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 6+ messages in thread* [Kernel-janitors] [PATCH 2.6.9-rc2 1/4] video/pxafb: replace
2004-09-20 22:12 [Kernel-janitors] [PATCH 2.6.9-rc2 1/4] message/device: replace Nishanth Aravamudan
` (2 preceding siblings ...)
2004-09-27 17:24 ` [Kernel-janitors] [PATCH 2.6.9-rc2 1/4] sbus/aurora: replace Nishanth Aravamudan
@ 2004-09-27 23:06 ` Nishanth Aravamudan
2004-09-27 23:17 ` [Kernel-janitors] [PATCH 2.6.9-rc2 1/4] w1/dscore: replace Nishanth Aravamudan
4 siblings, 0 replies; 6+ messages in thread
From: Nishanth Aravamudan @ 2004-09-27 23:06 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 565 bytes --]
Any comments would be appreciated.
Description: Use msleep() instead of schedule_timeout() to
guarantee the task delays as expected.
--- 2.6.9-rc2-vanilla/drivers/video/pxafb.c 2004-09-13 17:15:38.000000000 -0700
+++ 2.6.9-rc2/drivers/video/pxafb.c 2004-09-14 10:42:13.000000000 -0700
@@ -747,7 +747,7 @@ static void pxafb_disable_controller(str
LCCR0 &= ~LCCR0_LDM; /* Enable LCD Disable Done Interrupt */
LCCR0 |= LCCR0_DIS; /* Disable LCD Controller */
- schedule_timeout(20 * HZ / 1000);
+ msleep(20);
remove_wait_queue(&fbi->ctrlr_wait, &wait);
}
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 6+ messages in thread* [Kernel-janitors] [PATCH 2.6.9-rc2 1/4] w1/dscore: replace
2004-09-20 22:12 [Kernel-janitors] [PATCH 2.6.9-rc2 1/4] message/device: replace Nishanth Aravamudan
` (3 preceding siblings ...)
2004-09-27 23:06 ` [Kernel-janitors] [PATCH 2.6.9-rc2 1/4] video/pxafb: replace Nishanth Aravamudan
@ 2004-09-27 23:17 ` Nishanth Aravamudan
4 siblings, 0 replies; 6+ messages in thread
From: Nishanth Aravamudan @ 2004-09-27 23:17 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 682 bytes --]
Any comments would be appreciated.
Description: Use msleep_interruptible() instead of schedule_timeout() to
guarantee the task delays as expected.
--- 2.6.9-rc2-vanilla/drivers/w1/dscore.c 2004-09-13 17:16:07.000000000 -0700
+++ 2.6.9-rc2/drivers/w1/dscore.c 2004-09-27 16:16:47.000000000 -0700
@@ -23,6 +23,7 @@
#include <linux/kernel.h>
#include <linux/mod_devicetable.h>
#include <linux/usb.h>
+#include <linux/delay.h>
#include "dscore.h"
@@ -731,7 +732,7 @@ void ds_disconnect(struct usb_interface
usb_set_intfdata (intf, NULL);
while(atomic_read(&dev->refcnt))
- schedule_timeout(HZ);
+ msleep_interruptible(1000);
usb_put_dev(dev->udev);
kfree(dev);
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 6+ messages in thread