All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Christoph Hellwig <hch@lst.de>
Cc: Emoore@lsil.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] fusion: streamline ->queuecommand
Date: Sat, 2 Oct 2004 14:39:15 +0100	[thread overview]
Message-ID: <20041002133915.GR16153@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20041002081355.GA13643@lst.de>

On Sat, Oct 02, 2004 at 10:13:55AM +0200, Christoph Hellwig wrote:
> --- 1.50/drivers/message/fusion/mptscsih.c	2004-09-29 01:58:39 +02:00
> +++ edited/drivers/message/fusion/mptscsih.c	2004-10-01 12:45:04 +02:00
> @@ -1863,11 +1844,7 @@
>  
>  #ifdef MPTSCSIH_ENABLE_DOMAIN_VALIDATION
> +		int dvStatus = hd->ioc->spi_data.dvStatus[target];
> +		int issueCmd = 1;
> +
> +		if (dvStatus || hd->ioc->spi_data.forceDv) {
> +
> +			if ((dvStatus & MPT_SCSICFG_NEED_DV) ||
> +				(hd->ioc->spi_data.forceDv & MPT_SCSICFG_NEED_DV)) {
> +				unsigned long lflags;
> +				/* Schedule DV if necessary */

Of course, at some point, Fusion should be switched over to use the
scsi_transport_spi domain validation code ... not urgent, just an
item for the long-term todo list.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

  reply	other threads:[~2004-10-02 13:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-02  8:13 [PATCH] fusion: streamline ->queuecommand Christoph Hellwig
2004-10-02 13:39 ` Matthew Wilcox [this message]
2004-10-02 14:49   ` Christoph Hellwig
2004-10-21  9:21 ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2004-10-04 21:33 Moore, Eric Dean
2004-10-04 21:57 ` James Bottomley
2004-10-06 15:41 ` Christoph Hellwig
2004-10-05 22:38 Moore, Eric Dean
2004-10-05 23:11 ` James Bottomley
2004-10-05 23:37   ` Patrick Mansfield
2004-10-06  0:48     ` James Bottomley
2004-10-06 14:00 Gibbons, Terry
2004-10-06 14:13 ` Arjan van de Ven
2004-10-06 14:25 ` Matthew Wilcox
2004-10-06 14:23 Gibbons, Terry
2004-10-06 14:30 ` Christoph Hellwig
2004-10-06 15:47 ` James Bottomley
2004-10-06 14:46 Gibbons, Terry
2004-10-06 14:58 ` Matthew Wilcox
2004-10-21 14:58 Moore, Eric Dean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041002133915.GR16153@parcelfarce.linux.theplanet.co.uk \
    --to=matthew@wil.cx \
    --cc=Emoore@lsil.com \
    --cc=hch@lst.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.