Re: 2.6.9-mm1: timer_event multiple definition

[Adrian Bunk <bunk@stusta.de>]

On Fri, Oct 22, 2004 at 08:24:44AM -0700, Christoph Lameter wrote:
> On Fri, 22 Oct 2004, Adrian Bunk wrote:
> 
> >   LD      .tmp_vmlinux1
> > drivers/built-in.o(.text+0x30a210): In function `timer_event':
> > : multiple definition of `timer_event'
> > kernel/built-in.o(.text+0x16270): first defined here
> > ld: Warning: size of symbol `timer_event' changed from 157 in
> > kernel/built-in.o to 11 in drivers/built-in.o
> > make: *** [.tmp_vmlinux1] Error 1
> >
> > <--  snip  -->
> >
> >
> > I'd say drivers/net/skfp/queue.c is more at fault for using the pretty
> > generic timer_event name...
> 
> It built fine on my system ?!?.
>...


You don't have "SysKonnect FDDI PCI support" enabled in your .config?


That's what I wanted to say in my comment:


There's a name clash between two global `timer_event':
The one you introduced, and the one in drivers/net/skfp/queue.c .

I don't know whether `timer_event' is too generic for the use you 
introduced, but for the use in drivers/net/skfp/queue.c (which was 
already present) it seems too generic.


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed