All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, patrick.boettcher@desy.de
Cc: linux-kernel@vger.kernel.org, linux-dvb-maintainer@linuxtv.org
Subject: [patch] 2.6.9-mm1: dvb-dibusb.c: remove unused code
Date: Sat, 23 Oct 2004 02:44:18 +0200	[thread overview]
Message-ID: <20041023004416.GE22558@stusta.de> (raw)
In-Reply-To: <20041022032039.730eb226.akpm@osdl.org>

It seems the following warnings come from Linus' tree:

<--  snip  -->

...
  CC      drivers/media/dvb/dibusb/dvb-dibusb.o
drivers/media/dvb/dibusb/dvb-dibusb.c:308: warning: 'dibusb_interrupt_read_loop' defined but not used
drivers/media/dvb/dibusb/dvb-dibusb.c:318: warning: 'dibusb_read_remote_control' defined but not used
drivers/media/dvb/dibusb/dvb-dibusb.c:345: warning: 'dibusb_hw_sleep' defined but not used
drivers/media/dvb/dibusb/dvb-dibusb.c:351: warning: 'dibusb_hw_wakeup' defined but not used
...

<--  snip  -->


The patch below removes the unused code from this file.


diffstat output:
 drivers/media/dvb/dibusb/dvb-dibusb.c |   62 --------------------------
 1 files changed, 62 deletions(-)



Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.9-mm1-full/drivers/media/dvb/dibusb/dvb-dibusb.c.old	2004-10-23 02:37:56.000000000 +0200
+++ linux-2.6.9-mm1-full/drivers/media/dvb/dibusb/dvb-dibusb.c	2004-10-23 02:42:14.000000000 +0200
@@ -132,11 +132,6 @@
 	return ret;
 }
 
-static int dibusb_write_usb(struct usb_dibusb *dib, u8 *buf, u16 len)
-{
-	return dibusb_readwrite_usb(dib,buf,len,NULL,0);
-}
-
 static int dibusb_i2c_msg(struct usb_dibusb *dib, u8 addr,
 		u8 *wbuf, u16 wlen, u8 *rbuf, u16 rlen)
 {
@@ -297,63 +292,6 @@
 }
 
 /*
- * firmware transfers
- */
-
-/*
- * do not use this, just a workaround for a bug,
- * which will never occur :).
- */
-static int dibusb_interrupt_read_loop(struct usb_dibusb *dib)
-{
-	u8 b[1] = { DIBUSB_REQ_INTR_READ };
-	return dibusb_write_usb(dib,b,1);
-}
-
-/*
- * TODO: a tasklet should run with a delay of 1/10 second
- * and fill an appropriate event device ?
- */
-static int dibusb_read_remote_control(struct usb_dibusb *dib)
-{
-	u8 b[1] = { DIBUSB_REQ_POLL_REMOTE }, rb[5];
-	int ret;
-	if ((ret = dibusb_readwrite_usb(dib,b,1,rb,5)))
-		return ret;
-
-	return 0;
-}
-
-/*
- * ioctl for the firmware
- */
-static int dibusb_ioctl_cmd(struct usb_dibusb *dib, u8 cmd, u8 *param, int plen)
-{
-	u8 b[34];
-	int size = plen > 32 ? 32 : plen;
-	b[0] = DIBUSB_REQ_SET_IOCTL;
-	b[1] = cmd;
-	memcpy(&b[2],param,size);
-
-	return dibusb_write_usb(dib,b,2+size);
-}
-
-/*
- * ioctl for power control
- */
-static int dibusb_hw_sleep(struct usb_dibusb *dib)
-{
-	u8 b[1] = { DIBUSB_IOCTL_POWER_SLEEP };
-	return dibusb_ioctl_cmd(dib,DIBUSB_IOCTL_CMD_POWER_MODE, b,1);
-}
-
-static int dibusb_hw_wakeup(struct usb_dibusb *dib)
-{
-	u8 b[1] = { DIBUSB_IOCTL_POWER_WAKEUP };
-	return dibusb_ioctl_cmd(dib,DIBUSB_IOCTL_CMD_POWER_MODE, b,1);
-}
-
-/*
  * I2C
  */
 static int dibusb_i2c_xfer(struct i2c_adapter *adap,struct i2c_msg msg[],int num)



  parent reply	other threads:[~2004-10-23  0:49 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-22 10:20 2.6.9-mm1 Andrew Morton
2004-10-22 10:39 ` 2.6.9-mm1 Christoph Hellwig
2004-10-22 10:54   ` 2.6.9-mm1 Andrew Morton
2004-10-22 11:08     ` 2.6.9-mm1 Christoph Hellwig
2004-10-22 17:26       ` 2.6.9-mm1 Hans Reiser
2004-10-22 19:34       ` 2.6.9-mm1 Roman Zippel
2004-10-27 11:19         ` 2.6.9-mm1 Christoph Hellwig
2004-10-22 15:54   ` 2.6.9-mm1 Chris Wright
2004-10-22 12:23 ` 2.6.9-mm1 Eyal Lebedinsky
2004-10-22 19:26   ` 2.6.9-mm1 Adrian Bunk
2004-10-22 13:39 ` 2.6.9-mm1: pc_debug multiple definitions Adrian Bunk
2004-10-22 23:07   ` Russell King
2004-10-24  3:41   ` Luis R. Rodriguez
2004-10-24  3:41     ` Luis R. Rodriguez
2004-10-24  9:33     ` Adrian Bunk
2004-10-24 10:05       ` Luis R. Rodriguez
2004-10-24 10:05         ` Luis R. Rodriguez
2004-10-22 13:43 ` [patch] 2.6.9-mm1: usb/serial/console.c compile error Adrian Bunk
2004-10-22 18:08   ` Greg KH
2004-10-22 13:50 ` 2.6.9-mm1: timer_event multiple definition Adrian Bunk
2004-10-22 15:24   ` Christoph Lameter
2004-10-22 19:16     ` Adrian Bunk
2004-10-22 19:21       ` Christoph Lameter
2004-10-25 23:07     ` George Anzinger
2004-10-25 23:32       ` Christoph Lameter
2004-10-22 13:59 ` [patch] 2.6.9-mm1: ISDN hisax_fcpcipnp.c: kill unused variable Adrian Bunk
2004-10-22 15:30 ` 2.6.9-mm1 Jason Baron
2004-10-22 17:24 ` 2.6.9-mm1 Hans Reiser
2004-10-23 19:01   ` 2.6.9-mm1 Hilzinger Marcel
2004-10-23 19:39     ` 2.6.9-mm1 Andrew Morton
2004-10-23 19:49       ` 2.6.9-mm1 Jan Engelhardt
2004-10-24 17:42       ` 2.6.9-mm1 Alex Zarochentsev
2004-10-23 20:28     ` 2.6.9-mm1 Hans Reiser
2004-10-24 14:41   ` 2.6.9-mm1 Dr. Giovanni A. Orlando
2004-10-24 14:41   ` 2.6.9-mm1 Clifford Beshers
2004-10-24 14:45     ` 2.6.9-mm1 Con Kolivas
2004-10-24 14:54       ` 2.6.9-mm1 Clifford Beshers
2004-10-25 19:52   ` 2.6.9-mm1 Bill Davidsen
2004-10-22 21:06 ` 2.6.9-mm1 (compile stats) John Cherry
2004-10-22 22:22 ` 2.6.9-mm1 Chuck Harding
2004-10-24 18:00   ` 2.6.9-mm1 john cooper
2004-10-25 21:24     ` 2.6.9-mm1 Chuck Harding
2004-10-23  0:12 ` pdc202xx_old broke boot [was Re: 2.6.9-mm1] J.A. Magallon
2004-10-23  0:21   ` Andrew Morton
2004-10-23  0:22     ` J.A. Magallon
2004-10-23  0:34     ` Bartlomiej Zolnierkiewicz
2004-10-27 22:19       ` [PATCH] " J.A. Magallon
2004-10-27 22:42         ` Bartlomiej Zolnierkiewicz
2004-10-23  0:13 ` 2.6.9-mm1 Dominik Karall
2004-10-23 10:37   ` 2.6.9-mm1 Gerd Knorr
2004-10-23  0:44 ` Adrian Bunk [this message]
2004-10-23 10:48   ` [patch] 2.6.9-mm1: dvb-dibusb.c: remove unused code Patrick Boettcher
2004-10-23  7:22 ` 2.6.9-mm1 Avuton Olrich
2004-10-23 16:59   ` 2.6.9-mm1 Markus   Törnqvist
2004-10-23 22:03   ` 2.6.9-mm1 Kasper Sandberg
2004-10-25 19:54   ` 2.6.9-mm1 Bill Davidsen
2004-10-23  9:08 ` 2.6.9-mm1 Alexander Nyberg
2004-10-24  8:49   ` 2.6.9-mm1 Andrew Morton
2004-10-23 12:06 ` 2.6.9-mm1 Dominik Karall
2004-10-23 14:37 ` 2.6.9-mm1 Adrian Bunk
2004-10-23 15:55   ` 2.6.9-mm1 Hans Reiser
2004-10-23 16:57     ` 2.6.9-mm1 mjt
2004-10-23 16:57       ` 2.6.9-mm1 Markus   Törnqvist
2004-10-24  2:37       ` 2.6.9-mm1 David Masover
2004-10-24  0:47         ` 2.6.9-mm1 Jan Engelhardt
2004-10-24  5:14         ` 2.6.9-mm1 Hans Reiser
2004-10-24 19:40           ` 2.6.9-mm1 David Masover
2004-10-25 20:07           ` 2.6.9-mm1 Bill Davidsen
2004-10-25  0:12 ` 2.6.9-mm1 J.A. Magallon
2004-10-25 11:47 ` 2.6.9-mm1 Arjan van de Ven
2004-10-25 22:31 ` 2.6.9-mm1 Randy.Dunlap
2004-10-25 22:56   ` 2.6.9-mm1 Andrew Morton
2004-10-25 23:14     ` 2.6.9-mm1 Randy.Dunlap
2004-10-25 23:47       ` 2.6.9-mm1 Andrew Morton
2004-10-25 23:36         ` 2.6.9-mm1 Randy.Dunlap
2004-10-26  1:34           ` 2.6.9-mm1 Bartlomiej Zolnierkiewicz
2004-10-26  3:04             ` 2.6.9-mm1 Randy.Dunlap
2004-10-26 15:48               ` 2.6.9-mm1 Randy.Dunlap
2004-10-26 16:40                 ` 2.6.9-mm1 Bartlomiej Zolnierkiewicz
2004-10-26 20:01                   ` 2.6.9-mm1 Randy.Dunlap
2004-10-26  6:49   ` 2.6.9-mm1 Nigel Cunningham
2004-10-26 17:58 ` 2.6.9-mm1 Alexander Nyberg
2004-10-26 20:19   ` 2.6.9-mm1 Andrew Morton
2004-10-31  4:17 ` 2.6.9-mm1 A little build system bug I guess Pedro Larroy
2004-10-31  8:10   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041023004416.GE22558@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=linux-dvb-maintainer@linuxtv.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrick.boettcher@desy.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.