* Re: [KJ] [PATCH] net/ewrk3: replace schedule_timeout() with
2004-10-22 23:26 [KJ] [PATCH] net/ewrk3: replace schedule_timeout() with Nishanth Aravamudan
@ 2004-10-22 23:30 ` Jon Masters
2004-10-22 23:33 ` Nishanth Aravamudan
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Jon Masters @ 2004-10-22 23:30 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 469 bytes --]
On Fri, 22 Oct 2004 16:26:43 -0700, Nishanth Aravamudan <nacc@us.ibm.com> wrote:
> Any comments would be, as always, appreciated.
> /* Wait a little while */
> spin_unlock_irqrestore(&lp->hw_lock, flags);
> - set_current_state(TASK_UNINTERRUPTIBLE);
> - schedule_timeout(HZ>>2);
> + msleep(250);
> spin_lock_irqsave(&lp->hw_lock, flags);
That delay seems a little long.
Jon.
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [KJ] [PATCH] net/ewrk3: replace schedule_timeout() with
2004-10-22 23:26 [KJ] [PATCH] net/ewrk3: replace schedule_timeout() with Nishanth Aravamudan
2004-10-22 23:30 ` Jon Masters
@ 2004-10-22 23:33 ` Nishanth Aravamudan
2004-10-22 23:34 ` Jon Masters
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Nishanth Aravamudan @ 2004-10-22 23:33 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
On Sat, Oct 23, 2004 at 12:30:03AM +0100, Jon Masters wrote:
> On Fri, 22 Oct 2004 16:26:43 -0700, Nishanth Aravamudan <nacc@us.ibm.com> wrote:
>
> > Any comments would be, as always, appreciated.
>
> > /* Wait a little while */
> > spin_unlock_irqrestore(&lp->hw_lock, flags);
> > - set_current_state(TASK_UNINTERRUPTIBLE);
> > - schedule_timeout(HZ>>2);
> > + msleep(250);
> > spin_lock_irqsave(&lp->hw_lock, flags);
>
> That delay seems a little long.
Do you mean in the original driver or in my conversion?
-Nish
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [KJ] [PATCH] net/ewrk3: replace schedule_timeout() with
2004-10-22 23:26 [KJ] [PATCH] net/ewrk3: replace schedule_timeout() with Nishanth Aravamudan
2004-10-22 23:30 ` Jon Masters
2004-10-22 23:33 ` Nishanth Aravamudan
@ 2004-10-22 23:34 ` Jon Masters
2004-10-22 23:40 ` Nishanth Aravamudan
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Jon Masters @ 2004-10-22 23:34 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 220 bytes --]
On Fri, 22 Oct 2004 16:33:43 -0700, Nishanth Aravamudan <nacc@us.ibm.com> wrote:
> Do you mean in the original driver or in my conversion?
Your conversion. Seems an order of magnitude larger than it needs to be.
Jon.
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [KJ] [PATCH] net/ewrk3: replace schedule_timeout() with
2004-10-22 23:26 [KJ] [PATCH] net/ewrk3: replace schedule_timeout() with Nishanth Aravamudan
` (2 preceding siblings ...)
2004-10-22 23:34 ` Jon Masters
@ 2004-10-22 23:40 ` Nishanth Aravamudan
2004-10-23 0:33 ` Jon Masters
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Nishanth Aravamudan @ 2004-10-22 23:40 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 645 bytes --]
On Sat, Oct 23, 2004 at 12:34:07AM +0100, Jon Masters wrote:
> On Fri, 22 Oct 2004 16:33:43 -0700, Nishanth Aravamudan <nacc@us.ibm.com> wrote:
>
> > Do you mean in the original driver or in my conversion?
>
> Your conversion. Seems an order of magnitude larger than it needs to be.
The original was:
schedule_timeout(HZ>>2);
Which is, if my math is right,
HZ (the number of jiffies in a second) shifted 2 bits right, or divided
by 4. In other words, the number of jiffies in a quarter-second.
250 is the number of milliseconds in a quarter-second.
Thus, I think, the values are equivalent. Please correct and slap
accordingly...
-Nish
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [KJ] [PATCH] net/ewrk3: replace schedule_timeout() with
2004-10-22 23:26 [KJ] [PATCH] net/ewrk3: replace schedule_timeout() with Nishanth Aravamudan
` (3 preceding siblings ...)
2004-10-22 23:40 ` Nishanth Aravamudan
@ 2004-10-23 0:33 ` Jon Masters
2004-10-24 14:07 ` maximilian attems
2004-10-25 16:08 ` Nishanth Aravamudan
6 siblings, 0 replies; 8+ messages in thread
From: Jon Masters @ 2004-10-23 0:33 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 226 bytes --]
On Fri, 22 Oct 2004 16:40:26 -0700, Nishanth Aravamudan <nacc@us.ibm.com> wrote:
> The original was:
>
> schedule_timeout(HZ>>2);
I just wandered whether that was kicking around and assuming some
smaller value of HZ.
Jon.
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [KJ] [PATCH] net/ewrk3: replace schedule_timeout() with
2004-10-22 23:26 [KJ] [PATCH] net/ewrk3: replace schedule_timeout() with Nishanth Aravamudan
` (4 preceding siblings ...)
2004-10-23 0:33 ` Jon Masters
@ 2004-10-24 14:07 ` maximilian attems
2004-10-25 16:08 ` Nishanth Aravamudan
6 siblings, 0 replies; 8+ messages in thread
From: maximilian attems @ 2004-10-24 14:07 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 337 bytes --]
On Fri, 22 Oct 2004, Nishanth Aravamudan wrote:
> Any comments would be, as always, appreciated.
>
> -Nish
>
> Description: Uses msleep() instead of schedule_timeout() to guarantee
> the task delays as expected.
>
applied,
didn't check the 2.4 value of that schedule_timeout(),
but old drives may still expect HZ = 100.
thanks maks
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [KJ] [PATCH] net/ewrk3: replace schedule_timeout() with
2004-10-22 23:26 [KJ] [PATCH] net/ewrk3: replace schedule_timeout() with Nishanth Aravamudan
` (5 preceding siblings ...)
2004-10-24 14:07 ` maximilian attems
@ 2004-10-25 16:08 ` Nishanth Aravamudan
6 siblings, 0 replies; 8+ messages in thread
From: Nishanth Aravamudan @ 2004-10-25 16:08 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 503 bytes --]
On Sat, Oct 23, 2004 at 01:33:33AM +0100, Jon Masters wrote:
> On Fri, 22 Oct 2004 16:40:26 -0700, Nishanth Aravamudan <nacc@us.ibm.com> wrote:
>
> > The original was:
> >
> > schedule_timeout(HZ>>2);
>
> I just wandered whether that was kicking around and assuming some
> smaller value of HZ.
I don't think it should matter, as the intended delay, on any system,
will be one quarter of a second. Now, whether schedule_timeout() really
achieves this for all arch's is a different question :)
-Nish
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 8+ messages in thread