From: Andi Kleen <ak@muc.de>
To: Prasanna S Panchamukhi <prasanna@in.ibm.com>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org,
Andrew Morton <akpm@osdl.org>,
suparna@in.ibm.com, dprobes@www-124.southbury.usf.ibm.com
Subject: Re: [0/3] PATCH Kprobes for x86_64- 2.6.9-final
Date: 28 Oct 2004 13:37:44 +0200
Date: Thu, 28 Oct 2004 13:37:44 +0200 [thread overview]
Message-ID: <20041028113744.GA82042@muc.de> (raw)
In-Reply-To: <20041028113208.GA11182@in.ibm.com>
On Thu, Oct 28, 2004 at 05:02:08PM +0530, Prasanna S Panchamukhi wrote:
> Hi,
>
> Below are the Kprobes patches ported to x86_64 architecture.
> I have updated these patches with suggestions from Andi Kleen.
> Thanks Andi for reviewing and providing your feedback.
> These patches can be applied over 2.6.9-final. Please
> see the description in the individual patches.
>
> Please review and provide your feedback.
The patch is not ready to be applied yet. You didn't address
some issues from the last review.
Like I still would like to have the page fault notifier
completely moved out of the fast path into no_context
(that i386 has it there is also wrong). Adding kprobe_runn
doesn't make a difference.
And the jprobe_return_end change is wrong, my suggestion
was to move it into the inline assembler statement. Adding asmlinkage
doesn't help at all
(I think i386 gets this wrong too)
-Andi
next prev parent reply other threads:[~2004-10-28 11:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-28 11:32 [0/3] PATCH Kprobes for x86_64- 2.6.9-final Prasanna S Panchamukhi
2004-10-28 11:34 ` [1/3] " Prasanna S Panchamukhi
2004-10-28 11:35 ` [2/3] " Prasanna S Panchamukhi
2004-10-28 11:38 ` [3/3] " Prasanna S Panchamukhi
2004-10-30 21:06 ` [patch 3/3] kprobes : Minor changes for sparc64 Prasanna S Panchamukhi
2004-10-30 21:03 ` [patch 2/3] kprobes : kprobes ported to x86_64 Prasanna S Panchamukhi
2004-10-30 20:59 ` [patch 1/3] kprobes: Minor i386 changes required for porting kprobes " Prasanna S Panchamukhi
2004-10-28 11:37 ` Andi Kleen [this message]
2004-10-28 15:53 ` [0/3] PATCH Kprobes for x86_64- 2.6.9-final Prasanna S Panchamukhi
2004-10-28 23:42 ` Andi Kleen
2004-10-28 18:15 ` David S. Miller
2004-10-28 23:41 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041028113744.GA82042@muc.de \
--to=ak@muc.de \
--cc=akpm@osdl.org \
--cc=dprobes@www-124.southbury.usf.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=prasanna@in.ibm.com \
--cc=suparna@in.ibm.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.