From: Andi Kleen <ak@muc.de>
To: Prasanna S Panchamukhi <prasanna@in.ibm.com>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org,
Andrew Morton <akpm@osdl.org>,
suparna@in.ibm.com, dprobes@www-124.southbury.usf.ibm.com
Subject: Re: [0/3] PATCH Kprobes for x86_64- 2.6.9-final
Date: 29 Oct 2004 01:42:17 +0200
Date: Fri, 29 Oct 2004 01:42:17 +0200 [thread overview]
Message-ID: <20041028234217.GC80511@muc.de> (raw)
In-Reply-To: <20041028155359.GB11182@in.ibm.com>
On Thu, Oct 28, 2004 at 09:23:59PM +0530, Prasanna S Panchamukhi wrote:
>
> On Thu, Oct 28, 2004 at 01:37:44PM +0200, Andi Kleen wrote:
> >
> > Like I still would like to have the page fault notifier
> > completely moved out of the fast path into no_context
> > (that i386 has it there is also wrong). Adding kprobe_runn
> > doesn't make a difference.
>
> The kprobes fault handler is called if an exception is
> generated for any instruction within the fault-handler or when
> Kprobes single-steps the probed instruction.
> AFAIK kprobes does not handle page faults in the above case and just returns
> immediately resuming the normal execution.
Ok. It's ugly, but ok. Can you remove the bogus kprobes_running()
then please, it's unnecessary?
With that change it would be ok to merge from my side.
-Andi
next prev parent reply other threads:[~2004-10-29 2:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-28 11:32 [0/3] PATCH Kprobes for x86_64- 2.6.9-final Prasanna S Panchamukhi
2004-10-28 11:34 ` [1/3] " Prasanna S Panchamukhi
2004-10-28 11:35 ` [2/3] " Prasanna S Panchamukhi
2004-10-28 11:38 ` [3/3] " Prasanna S Panchamukhi
2004-10-30 21:06 ` [patch 3/3] kprobes : Minor changes for sparc64 Prasanna S Panchamukhi
2004-10-30 21:03 ` [patch 2/3] kprobes : kprobes ported to x86_64 Prasanna S Panchamukhi
2004-10-30 20:59 ` [patch 1/3] kprobes: Minor i386 changes required for porting kprobes " Prasanna S Panchamukhi
2004-10-28 11:37 ` [0/3] PATCH Kprobes for x86_64- 2.6.9-final Andi Kleen
2004-10-28 15:53 ` Prasanna S Panchamukhi
2004-10-28 23:42 ` Andi Kleen [this message]
2004-10-28 18:15 ` David S. Miller
2004-10-28 23:41 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041028234217.GC80511@muc.de \
--to=ak@muc.de \
--cc=akpm@osdl.org \
--cc=dprobes@www-124.southbury.usf.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=prasanna@in.ibm.com \
--cc=suparna@in.ibm.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.