All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carlo Perassi <carlo@linux.it>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] driver/net/tg3.c: some s/int/unsigned int
Date: Thu, 04 Nov 2004 09:35:09 +0000	[thread overview]
Message-ID: <20041104093509.GA4270@voyager> (raw)
In-Reply-To: <20041102101835.GA4083@voyager>

[-- Attachment #1: Type: text/plain, Size: 584 bytes --]

> Actually, the existing tests are wrong and have an off-by-1
> error as well, they should all be "if (limit < 0)"

When I wrote "tested" I mean I used (and I'm still using) for some days
a kernel with these changes without finding weakness in its behavior or
something alike.

You are right about the actual errors and my errors too (and the snippet
you talked about is the only non that trivial part of the patch, and it
was wrong :P)

Please let me know if you'd like a new version without the "if"s or not.

Thanks for your email.

-- 
Carlo Perassi - http://www.linux.it/~carlo/

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2004-11-04  9:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-02 10:18 [KJ] [PATCH] driver/net/tg3.c: some s/int/unsigned int Carlo Perassi
2004-11-02 10:55 ` Carlo Perassi
2004-11-02 22:16 ` Felipe W Damasio
2004-11-03  7:43 ` Carlo Perassi
2004-11-03 10:37 ` Carlo Perassi
2004-11-03 23:59 ` David S. Miller
2004-11-04  9:35 ` Carlo Perassi [this message]
2004-11-08  8:07 ` Carlo Perassi
2004-11-11 22:54 ` David S. Miller
2004-11-12  0:14 ` Stefan Sperling
2004-11-12 10:27 ` Carlo Perassi
2004-11-12 11:29 ` Carlo Perassi
2004-11-12 15:13 ` Carlo Perassi
2004-11-18  0:23 ` David S. Miller
2004-11-18  9:35 ` Carlo Perassi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041104093509.GA4270@voyager \
    --to=carlo@linux.it \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.