Re: [KJ] [PATCH] driver/net/tg3.c: some s/int/unsigned int

From: Stefan Sperling <stefan@binarchy.net>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] driver/net/tg3.c: some s/int/unsigned int
Date: Fri, 12 Nov 2004 00:14:31 +0000	[thread overview]
Message-ID: <20041112001431.GA8059@dice.seeling33.de> (raw)
In-Reply-To: <20041102101835.GA4083@voyager>

[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]

On Thu, Nov 11, 2004 at 02:54:20PM -0800, David S. Miller wrote:
> On Mon, 8 Nov 2004 09:07:26 +0100
> Carlo Perassi <carlo@linux.it> wrote:
> 
> > > Please let me know if you'd like a new version without the "if"s or not.
> > 
> > this is the new version with the discussed changes
> 
> Carlo... please look at this carefully:
> 
> @@ -518,7 +519,8 @@ static int tg3_readphy(struct tg3 *tp, i
>  static int tg3_writephy(struct tg3 *tp, int reg, u32 val)
>  {
>  	u32 frame_val;
> -	int loops, ret;
> +	int ret;
> +	unsigned int loops;
>  
>  	if ((tp->mi_mode & MAC_MI_MODE_AUTO_POLL) != 0) {
>  		tw32_f(MAC_MI_MODE,
> @@ -595,7 +597,7 @@ static int tg3_bmcr_reset(struct tg3 *tp
>  		}
>  		udelay(10);
>  	}
> -	if (limit <= 0)
> +	if (limit < 0)
>  		return -EBUSY;
> 
> How can an "unsigned" value every be less than zero?
> Didn't the compiler even warn you about this?

Er, where's the declaration of limit in the above code snippet?

;-)
stefan
-- 
Give me a fish and I will eat today.
Teach me to fish and I will eat forever.

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors