From: Felipe W Damasio <felipewd@terra.com.br>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] driver/net/tg3.c: some s/int/unsigned int
Date: Tue, 02 Nov 2004 22:16:19 +0000 [thread overview]
Message-ID: <41880733.4060300@terra.com.br> (raw)
In-Reply-To: <20041102101835.GA4083@voyager>
[-- Attachment #1: Type: text/plain, Size: 393 bytes --]
Carlo,
Carlo Perassi wrote:
> static int fiber_autoneg(struct tg3 *tp, u32 *flags)
> {
> - int res = 0;
> struct tg3_fiber_aneginfo aninfo;
> int status = ANEG_FAILED;
> + unsigned int res = 0;
> unsigned int tick;
> u32 tmp;
pedantic comment: Shouldn't you change the function header to "static
unsigned int", instead of forcing a cast back to int on return?
Cheers,
Felipe
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2004-11-02 22:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-02 10:18 [KJ] [PATCH] driver/net/tg3.c: some s/int/unsigned int Carlo Perassi
2004-11-02 10:55 ` Carlo Perassi
2004-11-02 22:16 ` Felipe W Damasio [this message]
2004-11-03 7:43 ` Carlo Perassi
2004-11-03 10:37 ` Carlo Perassi
2004-11-03 23:59 ` David S. Miller
2004-11-04 9:35 ` Carlo Perassi
2004-11-08 8:07 ` Carlo Perassi
2004-11-11 22:54 ` David S. Miller
2004-11-12 0:14 ` Stefan Sperling
2004-11-12 10:27 ` Carlo Perassi
2004-11-12 11:29 ` Carlo Perassi
2004-11-12 15:13 ` Carlo Perassi
2004-11-18 0:23 ` David S. Miller
2004-11-18 9:35 ` Carlo Perassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41880733.4060300@terra.com.br \
--to=felipewd@terra.com.br \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.