From: greg@kroah.com (Greg KH)
To: Justin Thiessen <jthiessen@penguincomputing.com>
Cc: linux-kernel@vger.kernel.org, sensors@Stimpy.netroedge.com,
phil@netroedge.com
Subject: [PATCH] 2.6 lm85.c driver update
Date: Thu, 19 May 2005 06:25:21 +0000 [thread overview]
Message-ID: <20041105214841.GI1750@kroah.com> (raw)
In-Reply-To: <20041025220526.GC19053@penguincomputing.com>
On Mon, Oct 25, 2004 at 03:05:26PM -0700, Justin Thiessen wrote:
> On Mon, Oct 25, 2004 at 10:59:59PM +0200, Jean Delvare wrote:
> > > > Hm, there are a number of rejects in this patch. Care to resync up
> > > > with the next kernel release and resend this?
> > >
> > > Ok, try this:
> > >
> > > signed off by: Justin Thiessen <jthiessen@penguincomputing.com>
> > >
> > > patch for kernel 2.6.X lm85 driver follows:
> > > ----------------------------------------------------
> > >
> > > --- linux-2.6.9/drivers/i2c/chips/lm85.c.orig 2004-10-18 14:53:46.000000000 -0700
> > > +++ linux-2.6.9/drivers/i2c/chips/lm85.c 2004-10-24 18:16:04.188509824 -0700
> >
> > Unfortunately this won't be OK either. 2.6.10-rc1 has a lot of i2c
> > changes, including a number of things your patch attempts to fix (macro
> > abuse reported by Mark Hoffman). So it won't apply to Greg's tree.
>
>
> Aiiiiiiiieeeeeee.
>
>
> > Please provide your patch against 2.6.10-rc1. Sorry that you always seem
> > to provide your patch against the not-really-last tree ;)
>
> It's not your fault I expect kernel releases to be rolled out by punchcards and
> horse-drawn wagon.
>
> Thanks for the heads-up; see the following patch for a new, "improved" version.
Applied, thanks.
But now I get the following build warnings:
drivers/i2c/chips/lm85.c:220: warning: 'SMOOTH_TO_REG' defined but not used
drivers/i2c/chips/lm85.c:236: warning: 'SPINUP_TO_REG' defined but not used
Care to send me a patch to fix them up?
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Justin Thiessen <jthiessen@penguincomputing.com>
Cc: linux-kernel@vger.kernel.org, sensors@Stimpy.netroedge.com,
phil@netroedge.com
Subject: Re: [PATCH] 2.6 lm85.c driver update
Date: Fri, 5 Nov 2004 13:48:41 -0800 [thread overview]
Message-ID: <20041105214841.GI1750@kroah.com> (raw)
In-Reply-To: <20041025220526.GC19053@penguincomputing.com>
On Mon, Oct 25, 2004 at 03:05:26PM -0700, Justin Thiessen wrote:
> On Mon, Oct 25, 2004 at 10:59:59PM +0200, Jean Delvare wrote:
> > > > Hm, there are a number of rejects in this patch. Care to resync up
> > > > with the next kernel release and resend this?
> > >
> > > Ok, try this:
> > >
> > > signed off by: Justin Thiessen <jthiessen@penguincomputing.com>
> > >
> > > patch for kernel 2.6.X lm85 driver follows:
> > > ----------------------------------------------------
> > >
> > > --- linux-2.6.9/drivers/i2c/chips/lm85.c.orig 2004-10-18 14:53:46.000000000 -0700
> > > +++ linux-2.6.9/drivers/i2c/chips/lm85.c 2004-10-24 18:16:04.188509824 -0700
> >
> > Unfortunately this won't be OK either. 2.6.10-rc1 has a lot of i2c
> > changes, including a number of things your patch attempts to fix (macro
> > abuse reported by Mark Hoffman). So it won't apply to Greg's tree.
>
>
> Aiiiiiiiieeeeeee.
>
>
> > Please provide your patch against 2.6.10-rc1. Sorry that you always seem
> > to provide your patch against the not-really-last tree ;)
>
> It's not your fault I expect kernel releases to be rolled out by punchcards and
> horse-drawn wagon.
>
> Thanks for the heads-up; see the following patch for a new, "improved" version.
Applied, thanks.
But now I get the following build warnings:
drivers/i2c/chips/lm85.c:220: warning: 'SMOOTH_TO_REG' defined but not used
drivers/i2c/chips/lm85.c:236: warning: 'SPINUP_TO_REG' defined but not used
Care to send me a patch to fix them up?
thanks,
greg k-h
next prev parent reply other threads:[~2005-05-19 6:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-19 6:25 [PATCH] 2.6 lm85.c driver update Justin Thiessen
2005-05-19 6:25 ` Justin Thiessen
2004-11-05 21:48 ` Greg KH [this message]
2005-05-19 6:25 ` Greg KH
2004-11-05 22:25 ` Justin Thiessen
2005-05-19 6:25 ` Justin Thiessen
2004-11-09 0:49 ` Greg KH
2005-05-19 6:25 ` Greg KH
2005-05-19 6:25 ` Greg KH
2004-10-25 20:36 ` Justin Thiessen
2005-05-19 6:25 ` Justin Thiessen
2004-10-25 20:59 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041105214841.GI1750@kroah.com \
--to=greg@kroah.com \
--cc=jthiessen@penguincomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phil@netroedge.com \
--cc=sensors@Stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.