[KJ] [PATCH] MODULE_PARM in drivers/net/ppp_async.c

[KJ] [PATCH] MODULE_PARM in drivers/net/ppp_async.c

[Carlo Perassi]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

Hi.
Compiling 2.6.10-rc2 with ppp_async.ko I saw a warning about
MODULE_PARAM.
I do not know a lot on this topic, anyway I searched a bit about that
and tried to patch the ppp_async.c file.
I compiled (without getting the previous warning) and tested ppp with
the attached patch.
Please let me know if it is the proper way to patch it.
Thank you.

-- 
Carlo Perassi - http://www.linux.it/~carlo/

[-- Attachment #2: ppp_async.patch --]
[-- Type: text/plain, Size: 573 bytes --]

Signed-off-by: Carlo Perassi <carlo@linux.it>

---

--- linux-2.6.10-rc2-orig/drivers/net/ppp_async.c	2004-11-15 21:22:04.000000000 +0100
+++ linux-2.6.10-rc2-mod/drivers/net/ppp_async.c	2004-11-15 21:21:47.000000000 +0100
@@ -84,7 +84,7 @@ struct asyncppp {
 #define SC_RCV_BITS	(SC_RCV_B7_1|SC_RCV_B7_0|SC_RCV_ODDP|SC_RCV_EVNP)
 
 static int flag_time = HZ;
-MODULE_PARM(flag_time, "i");
+module_param(flag_time, int, 0444);
 MODULE_PARM_DESC(flag_time, "ppp_async: interval between flagged packets (in clock ticks)");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS_LDISC(N_PPP);

[-- Attachment #3: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] MODULE_PARM in drivers/net/ppp_async.c

[stefan]

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]

On Mon, Nov 15, 2004 at 09:36:11PM +0100, Carlo Perassi wrote:
> Hi.
> Compiling 2.6.10-rc2 with ppp_async.ko I saw a warning about
> MODULE_PARAM.
> I do not know a lot on this topic, anyway I searched a bit about that
> and tried to patch the ppp_async.c file.
> I compiled (without getting the previous warning) and tested ppp with
> the attached patch.
> Please let me know if it is the proper way to patch it.
> --- linux-2.6.10-rc2-orig/drivers/net/ppp_async.c	2004-11-15 21:22:04.000000000 +0100
> +++ linux-2.6.10-rc2-mod/drivers/net/ppp_async.c	2004-11-15 21:21:47.000000000 +0100
> @@ -84,7 +84,7 @@ struct asyncppp {
>  #define SC_RCV_BITS	(SC_RCV_B7_1|SC_RCV_B7_0|SC_RCV_ODDP|SC_RCV_EVNP)
>  
>  static int flag_time = HZ;
> -MODULE_PARM(flag_time, "i");
> +module_param(flag_time, int, 0444);
>  MODULE_PARM_DESC(flag_time, "ppp_async: interval between flagged packets (in clock ticks)");
>  MODULE_LICENSE("GPL");
>  MODULE_ALIAS_LDISC(N_PPP);


Looks good to me.

stefan

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors